diff --git a/oneflow/core/comm_network/ibverbs/ibverbs_comm_network.cpp b/oneflow/core/comm_network/ibverbs/ibverbs_comm_network.cpp index 2fa7a56a87d9dfe60d3ecd5c31af4f2525966db9..4a833cafd11889f529f3c9629c232e9006c62423 100644 --- a/oneflow/core/comm_network/ibverbs/ibverbs_comm_network.cpp +++ b/oneflow/core/comm_network/ibverbs/ibverbs_comm_network.cpp @@ -89,13 +89,13 @@ IBVerbsCommNet::IBVerbsCommNet() ibv_free_device_list(device_list); pd_ = ibv_alloc_pd(context_); CHECK(pd_); - ibv_device_attr device_attr; + ibv_device_attr device_attr{}; CHECK_EQ(ibv_query_device(context_, &device_attr), 0); cq_ = ibv_create_cq(context_, device_attr.max_cqe, nullptr, nullptr, 0); CHECK(cq_); - ibv_port_attr port_attr; + ibv_port_attr port_attr{}; CHECK_EQ(ibv_query_port(context_, 1, &port_attr), 0); - ibv_gid gid; + ibv_gid gid{}; CHECK_EQ(ibv_query_gid(context_, 1, 0, &gid), 0); int64_t this_machine_id = GlobalProcessCtx::Rank(); qp_vec_.assign(Global<ResourceDesc, ForEnv>::Get()->process_ranks().size(), nullptr); diff --git a/oneflow/core/comm_network/ibverbs/ibverbs_memory_desc.cpp b/oneflow/core/comm_network/ibverbs/ibverbs_memory_desc.cpp index 7b7b76aa01b487a84ca09d6adf775285eea757b5..54f0fbb8614414a41013cf85674818dd434cf39e 100644 --- a/oneflow/core/comm_network/ibverbs/ibverbs_memory_desc.cpp +++ b/oneflow/core/comm_network/ibverbs/ibverbs_memory_desc.cpp @@ -14,7 +14,6 @@ See the License for the specific language governing permissions and limitations under the License. */ #include "oneflow/core/comm_network/ibverbs/ibverbs_memory_desc.h" -#include "oneflow/core/job/job_desc.h" #include "oneflow/core/job/resource_desc.h" #include "oneflow/core/job/global_for.h" @@ -37,7 +36,7 @@ IBVerbsMemDesc::IBVerbsMemDesc(ibv_pd* pd, void* mem_ptr, size_t byte_size) { IBV_ACCESS_LOCAL_WRITE | IBV_ACCESS_REMOTE_WRITE | IBV_ACCESS_REMOTE_READ); CHECK(cur_mr); mr_vec_.push_back(cur_mr); - ibv_sge cur_sge; + ibv_sge cur_sge{}; cur_sge.addr = reinterpret_cast<uint64_t>(ch_mem_ptr); cur_sge.length = cur_size; cur_sge.lkey = cur_mr->lkey; diff --git a/oneflow/core/comm_network/ibverbs/ibverbs_qp.cpp b/oneflow/core/comm_network/ibverbs/ibverbs_qp.cpp index 600c28df41b7a0387c18cab43489787362b46397..0e97889befe61c03977434ed7b2467d3336e4a6a 100644 --- a/oneflow/core/comm_network/ibverbs/ibverbs_qp.cpp +++ b/oneflow/core/comm_network/ibverbs/ibverbs_qp.cpp @@ -34,12 +34,12 @@ IBVerbsQP::IBVerbsQP(ibv_context* ctx, ibv_pd* pd, ibv_cq* send_cq, ibv_cq* recv ctx_ = ctx; pd_ = pd; // qp_ - ibv_device_attr device_attr; + ibv_device_attr device_attr{}; CHECK_EQ(ibv_query_device(ctx, &device_attr), 0); uint32_t max_recv_wr = Global<ResourceDesc, ForSession>::Get()->rdma_recv_msg_buf_byte() / sizeof(ActorMsg); max_recv_wr = std::min<uint32_t>(max_recv_wr, device_attr.max_qp_wr); - ibv_qp_init_attr qp_init_attr; + ibv_qp_init_attr qp_init_attr{}; qp_init_attr.qp_context = nullptr; qp_init_attr.send_cq = send_cq; qp_init_attr.recv_cq = recv_cq; @@ -70,9 +70,9 @@ IBVerbsQP::~IBVerbsQP() { } void IBVerbsQP::Connect(const IBVerbsConnectionInfo& peer_info) { - ibv_port_attr port_attr; + ibv_port_attr port_attr{}; CHECK_EQ(ibv_query_port(ctx_, 1, &port_attr), 0); - ibv_qp_attr qp_attr; + ibv_qp_attr qp_attr{}; // IBV_QPS_INIT memset(&qp_attr, 0, sizeof(ibv_qp_attr)); qp_attr.qp_state = IBV_QPS_INIT; @@ -132,7 +132,7 @@ void IBVerbsQP::PostReadRequest(const IBVerbsMemDescProto& remote_mem, wr_id->outstanding_sge_cnt = local_mem.sge_vec().size(); wr_id->read_id = read_id; FOR_RANGE(size_t, i, 0, local_mem.sge_vec().size()) { - ibv_send_wr wr; + ibv_send_wr wr{}; wr.wr_id = reinterpret_cast<uint64_t>(wr_id); wr.next = nullptr; wr.sg_list = const_cast<ibv_sge*>(&(local_mem.sge_vec().at(i))); @@ -152,7 +152,7 @@ void IBVerbsQP::PostSendRequest(const ActorMsg& msg) { msg_mr->set_msg(msg); WorkRequestId* wr_id = NewWorkRequestId(); wr_id->msg_mr = msg_mr; - ibv_send_wr wr; + ibv_send_wr wr{}; wr.wr_id = reinterpret_cast<uint64_t>(wr_id); wr.next = nullptr; wr.sg_list = const_cast<ibv_sge*>(&(msg_mr->mem_desc().sge_vec().at(0))); @@ -191,7 +191,7 @@ void IBVerbsQP::RecvDone(WorkRequestId* wr_id) { void IBVerbsQP::PostRecvRequest(ActorMsgMR* msg_mr) { WorkRequestId* wr_id = NewWorkRequestId(); wr_id->msg_mr = msg_mr; - ibv_recv_wr wr; + ibv_recv_wr wr{}; wr.wr_id = reinterpret_cast<uint64_t>(wr_id); wr.next = nullptr; wr.sg_list = const_cast<ibv_sge*>(&(msg_mr->mem_desc().sge_vec().at(0)));