From b46a644ae7ad7a13d4d92077cf03c852c9bea9c3 Mon Sep 17 00:00:00 2001
From: Shivang Patel <shivaang14@gmail.com>
Date: Tue, 12 Nov 2019 21:04:48 -0500
Subject: [PATCH] address some more PR feedback.
---
.../nav2_lifecycle_manager/lifecycle_manager.hpp | 4 ++--
.../lifecycle_manager_client.hpp | 16 ++++++++--------
2 files changed, 10 insertions(+), 10 deletions(-)
diff --git a/nav2_lifecycle_manager/include/nav2_lifecycle_manager/lifecycle_manager.hpp b/nav2_lifecycle_manager/include/nav2_lifecycle_manager/lifecycle_manager.hpp
index b4e541a8..c8675893 100644
--- a/nav2_lifecycle_manager/include/nav2_lifecycle_manager/lifecycle_manager.hpp
+++ b/nav2_lifecycle_manager/include/nav2_lifecycle_manager/lifecycle_manager.hpp
@@ -33,8 +33,8 @@ namespace nav2_lifecycle_manager
using nav2_msgs::srv::ManageLifecycleNodes;
/**
* @class nav2_lifecycle_manager::LifecycleManager
- * @brief Implements service interface to control the lifecycle nodes of
- * Navigation2 stack. It receives control request and then uses lifecycle
+ * @brief Implements service interface to transition the lifecycle nodes of
+ * Navigation2 stack. It receives transition request and then uses lifecycle
* interface to change lifecycle node's state.
*/
class LifecycleManager : public rclcpp::Node
diff --git a/nav2_lifecycle_manager/include/nav2_lifecycle_manager/lifecycle_manager_client.hpp b/nav2_lifecycle_manager/include/nav2_lifecycle_manager/lifecycle_manager_client.hpp
index 5414b988..3b9f7970 100644
--- a/nav2_lifecycle_manager/include/nav2_lifecycle_manager/lifecycle_manager_client.hpp
+++ b/nav2_lifecycle_manager/include/nav2_lifecycle_manager/lifecycle_manager_client.hpp
@@ -49,46 +49,46 @@ public:
// Client-side interface to the Nav2 lifecycle manager
/**
- * @brief Makes start up service call
+ * @brief Make start up service call
* @return true or false
*/
bool startup();
/**
- * @brief Makes shutdown service call
+ * @brief Make shutdown service call
* @return true or false
*/
bool shutdown();
/**
- * @brief Makes pause service call
+ * @brief Make pause service call
* @return true or false
*/
bool pause();
/**
- * @brief Makes resume service call
+ * @brief Make resume service call
* @return true or false
*/
bool resume();
/**
- * @brief Makes reset service call
+ * @brief Make reset service call
* @return true or false
*/
bool reset();
/**
- * @brief Checks if lifecycle node manager server is active
+ * @brief Check if lifecycle node manager server is active
* @return ACTIVE or INACTIVE or TIMEOUT
*/
SystemStatus is_active(const std::chrono::nanoseconds timeout = std::chrono::nanoseconds(-1));
// A couple convenience methods to facilitate scripting tests
/**
- * @brief Sets initial pose with covariance
+ * @brief Set initial pose with covariance
* @param x X position
* @param y Y position
* @param theta orientation
*/
void set_initial_pose(double x, double y, double theta);
/**
- * @brief Sends goal pose to NavigationToPose action server
+ * @brief Send goal pose to NavigationToPose action server
* @param x X position
* @param y Y position
* @param theta orientation
--
GitLab