From 0e380806151b8e6d24e5dce2a7e654a3c4162a31 Mon Sep 17 00:00:00 2001 From: will <349071347@qq.com> Date: Thu, 22 Oct 2020 15:59:23 +0800 Subject: [PATCH] optimize: no longer substring the message in rpc transmission (#3201) --- .../seata/protocol/AbstractResultMessageCodec.java | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/serializer/seata-serializer-seata/src/main/java/io/seata/serializer/seata/protocol/AbstractResultMessageCodec.java b/serializer/seata-serializer-seata/src/main/java/io/seata/serializer/seata/protocol/AbstractResultMessageCodec.java index 335576da5..dbd1bc9a3 100644 --- a/serializer/seata-serializer-seata/src/main/java/io/seata/serializer/seata/protocol/AbstractResultMessageCodec.java +++ b/serializer/seata-serializer-seata/src/main/java/io/seata/serializer/seata/protocol/AbstractResultMessageCodec.java @@ -29,8 +29,6 @@ import io.seata.core.protocol.ResultCode; */ public abstract class AbstractResultMessageCodec extends AbstractMessageCodec { - private static final int MAX_ERR_MSG_LEN = 128; - @Override public Class<?> getMessageClassType() { return AbstractResultMessage.class; @@ -46,16 +44,14 @@ public abstract class AbstractResultMessageCodec extends AbstractMessageCodec { if (resultCode == ResultCode.Failed) { if (StringUtils.isNotEmpty(resultMsg)) { String msg; - if (resultMsg.length() > MAX_ERR_MSG_LEN) { - msg = resultMsg.substring(0, MAX_ERR_MSG_LEN) + "..."; + if (resultMsg.length() > Short.MAX_VALUE) { + msg = resultMsg.substring(0, Short.MAX_VALUE); } else { msg = resultMsg; } byte[] bs = msg.getBytes(UTF8); out.writeShort((short)bs.length); - if (bs.length > 0) { - out.writeBytes(bs); - } + out.writeBytes(bs); } else { out.writeShort((short)0); } -- GitLab