From 38279a0c11deae9e7cee19a52275921d3ff011d9 Mon Sep 17 00:00:00 2001 From: chenhaozhe <chenhaozhe1@huawei.com> Date: Tue, 8 Mar 2022 17:01:15 +0800 Subject: [PATCH] update PULL_REQUEST_TEMPLATE, add the checklist --- .gitee/PULL_REQUEST_TEMPLATE.md | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) diff --git a/.gitee/PULL_REQUEST_TEMPLATE.md b/.gitee/PULL_REQUEST_TEMPLATE.md index 597841e86..e221f8ec5 100644 --- a/.gitee/PULL_REQUEST_TEMPLATE.md +++ b/.gitee/PULL_REQUEST_TEMPLATE.md @@ -26,3 +26,19 @@ Fixes # **Special notes for your reviewers**: +**CheckList**: + +- [ ] I have added correct copyrights for every code file. +- [ ] I have removed all the redundant code and comments. +- [ ] I have updated or added the `requirements.txt` for the third-party libraries you need. +- [ ] I have made sure that I won't expose any personaly information such as local path with user name, local IP, etc. +- [ ] I have commented my code, particularly in hard-to-understand areas. All the comments in code files are in English. +- [ ] I have made corresponding changes to the documentation. +- [ ] I have squashed all the commits into one. +- [ ] I have checked the following usual mistakes: + - [ ] It is recommended to use `bash` instead of `sh`. + - [ ] Don't use `type=bool` in argparse. +- [ ] If you are contributing a new model, please check: + - [ ] I have added at least one `README` + - [ ] The models implemented for the cloud could work offline on the local server as well. + - [ ] I have made sure the changes for new device target will not make differences on the original one. -- GitLab