From 03e19b3f1643cfcf03c497911e39d38ca64d1087 Mon Sep 17 00:00:00 2001 From: CodingSinger <ooczzoo@gmail.com> Date: Tue, 31 Mar 2020 13:12:23 +0800 Subject: [PATCH] fix comments --- registry/zookeeper/registry.go | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/registry/zookeeper/registry.go b/registry/zookeeper/registry.go index bfbb71d53..895242afc 100644 --- a/registry/zookeeper/registry.go +++ b/registry/zookeeper/registry.go @@ -190,9 +190,11 @@ func (r *zkRegistry) getListener(conf *common.URL) (*RegistryConfigurationListen var zkListener *RegistryConfigurationListener if r.dataListener.subscribed[conf] != nil { - zkListener, err := r.dataListener.subscribed[conf].(*RegistryConfigurationListener) - if err != nil && zkListener.isClosed { - return nil, perrors.New("zk connection broken") + zkListener, _ := r.dataListener.subscribed[conf].(*RegistryConfigurationListener) + r.listenerLock.Lock() + if zkListener.isClosed { + r.listenerLock.Unlock() + return nil, perrors.New("configListener already been closed") } } @@ -219,5 +221,6 @@ func (r *zkRegistry) getListener(conf *common.URL) (*RegistryConfigurationListen go r.listener.ListenServiceEvent(fmt.Sprintf("/dubbo/%s/"+constant.DEFAULT_CATEGORY, url.QueryEscape(conf.Service())), r.dataListener) + return zkListener, nil } -- GitLab