diff --git a/cluster/directory/base_directory_test.go b/cluster/directory/base_directory_test.go index 91c288f9979977c70fd4e5a2e74b2b70a51d6baf..16e3c5a960912af66739bcc1c5736d44d437503e 100644 --- a/cluster/directory/base_directory_test.go +++ b/cluster/directory/base_directory_test.go @@ -42,7 +42,7 @@ var ( func TestNewBaseDirectory(t *testing.T) { dir := NewBaseDirectory(url) assert.Equal(t, url, dir.GetUrl()) - assert.Equal(t, &url, dir.GetDirectoryUrl()) + assert.Equal(t, url, dir.GetDirectoryUrl()) } func TestBuildRouterChain(t *testing.T) { diff --git a/common/url.go b/common/url.go index d42012b66e6658dfed582400f6a30516a7a4526c..357094c688ab76d1de3f2eaf58a2d7df34d38fc5 100644 --- a/common/url.go +++ b/common/url.go @@ -402,9 +402,6 @@ func (c *URL) Service() string { func (c *URL) AddParam(key string, value string) { c.paramsLock.Lock() defer c.paramsLock.Unlock() - if len(value) == 0 { - return - } c.params.Add(key, value) } @@ -415,9 +412,6 @@ func (c *URL) AddParamAvoidNil(key string, value string) { if c.params == nil { c.params = url.Values{} } - if len(value) == 0 { - return - } c.params.Add(key, value) } @@ -426,9 +420,6 @@ func (c *URL) AddParamAvoidNil(key string, value string) { func (c *URL) SetParam(key string, value string) { c.paramsLock.Lock() defer c.paramsLock.Unlock() - if len(value) == 0 { - return - } c.params.Set(key, value) }