From 03f164ab83b6fb4b13101ea588cdc285a55fdce3 Mon Sep 17 00:00:00 2001
From: haohongfan <haohongfan@ling.ai>
Date: Sun, 15 Nov 2020 15:09:55 +0800
Subject: [PATCH] feat: update
---
cluster/directory/base_directory_test.go | 2 +-
common/url.go | 9 ---------
2 files changed, 1 insertion(+), 10 deletions(-)
diff --git a/cluster/directory/base_directory_test.go b/cluster/directory/base_directory_test.go
index 91c288f99..16e3c5a96 100644
--- a/cluster/directory/base_directory_test.go
+++ b/cluster/directory/base_directory_test.go
@@ -42,7 +42,7 @@ var (
func TestNewBaseDirectory(t *testing.T) {
dir := NewBaseDirectory(url)
assert.Equal(t, url, dir.GetUrl())
- assert.Equal(t, &url, dir.GetDirectoryUrl())
+ assert.Equal(t, url, dir.GetDirectoryUrl())
}
func TestBuildRouterChain(t *testing.T) {
diff --git a/common/url.go b/common/url.go
index d42012b66..357094c68 100644
--- a/common/url.go
+++ b/common/url.go
@@ -402,9 +402,6 @@ func (c *URL) Service() string {
func (c *URL) AddParam(key string, value string) {
c.paramsLock.Lock()
defer c.paramsLock.Unlock()
- if len(value) == 0 {
- return
- }
c.params.Add(key, value)
}
@@ -415,9 +412,6 @@ func (c *URL) AddParamAvoidNil(key string, value string) {
if c.params == nil {
c.params = url.Values{}
}
- if len(value) == 0 {
- return
- }
c.params.Add(key, value)
}
@@ -426,9 +420,6 @@ func (c *URL) AddParamAvoidNil(key string, value string) {
func (c *URL) SetParam(key string, value string) {
c.paramsLock.Lock()
defer c.paramsLock.Unlock()
- if len(value) == 0 {
- return
- }
c.params.Set(key, value)
}
--
GitLab