From 0d78b2a65f1c35e93682adeed0d62b0d5e3c679e Mon Sep 17 00:00:00 2001
From: "vito.he" <hxmhlt@163.com>
Date: Sun, 24 May 2020 12:02:51 +0800
Subject: [PATCH] Mod:for code review
---
metadata/definition/definition.go | 4 ++--
metadata/report/delegate/delegate_report_test.go | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/metadata/definition/definition.go b/metadata/definition/definition.go
index c8dd86b18..fa195d09d 100644
--- a/metadata/definition/definition.go
+++ b/metadata/definition/definition.go
@@ -91,8 +91,8 @@ type TypeDefinition struct {
}
// BuildServiceDefinition can build service definition which will be used to describe a service
-func BuildServiceDefinition(service common.Service, url common.URL) ServiceDefinition {
- sd := ServiceDefinition{}
+func BuildServiceDefinition(service common.Service, url common.URL) *ServiceDefinition {
+ sd := &ServiceDefinition{}
sd.CanonicalName = url.Service()
for k, m := range service.Method() {
diff --git a/metadata/report/delegate/delegate_report_test.go b/metadata/report/delegate/delegate_report_test.go
index 0e8da6070..04c9e6483 100644
--- a/metadata/report/delegate/delegate_report_test.go
+++ b/metadata/report/delegate/delegate_report_test.go
@@ -106,7 +106,7 @@ func TestMetadataReport_StoreProviderMetadata(t *testing.T) {
mtr.StoreProviderMetadata(metadataId, getMockDefinition(metadataId, t))
}
-func getMockDefinition(id *identifier.MetadataIdentifier, t *testing.T) definition.ServiceDefinition {
+func getMockDefinition(id *identifier.MetadataIdentifier, t *testing.T) *definition.ServiceDefinition {
protocol := "dubbo"
beanName := "UserProvider"
url, err := common.NewURL(fmt.Sprintf(
--
GitLab