From 10d0ac89b832248038b2a35d930a72894b0b8067 Mon Sep 17 00:00:00 2001
From: flycash <flycash@apache.org>
Date: Mon, 27 Jan 2020 12:53:37 +0800
Subject: [PATCH] Fix BUG
---
filter/filter_impl/metrics_filter.go | 2 +-
metrics/prometheus/reporter_test.go | 4 ++++
2 files changed, 5 insertions(+), 1 deletion(-)
diff --git a/filter/filter_impl/metrics_filter.go b/filter/filter_impl/metrics_filter.go
index d07dc2268..1e2dc35f2 100644
--- a/filter/filter_impl/metrics_filter.go
+++ b/filter/filter_impl/metrics_filter.go
@@ -63,7 +63,7 @@ func (p *metricsFilter) Invoke(ctx context.Context, invoker protocol.Invoker, in
duration := end.Sub(start)
go func() {
for _, reporter := range p.reporters {
- reporter.Report(ctx, invoker, invocation, duration, nil)
+ reporter.Report(ctx, invoker, invocation, duration, res)
}
}()
return res
diff --git a/metrics/prometheus/reporter_test.go b/metrics/prometheus/reporter_test.go
index 4f734ac8b..52e8b50c5 100644
--- a/metrics/prometheus/reporter_test.go
+++ b/metrics/prometheus/reporter_test.go
@@ -23,6 +23,9 @@ import (
"time"
)
+import (
+ "github.com/stretchr/testify/assert"
+)
import (
"github.com/apache/dubbo-go/common"
"github.com/apache/dubbo-go/common/extension"
@@ -43,6 +46,7 @@ func TestPrometheusReporter_Report(t *testing.T) {
attach := make(map[string]string, 10)
inv := invocation.NewRPCInvocation("MethodName", []interface{}{"OK", "Hello"}, attach)
+ assert.False(t, isConsumer(url))
ctx := context.Background()
reporter.Report(ctx, invoker, inv, 100*time.Millisecond, nil)
}
--
GitLab