diff --git a/registry/factory.go b/registry/factory.go deleted file mode 100644 index bb20e9dd3ebcd83532ac57e178b3e73414090b5d..0000000000000000000000000000000000000000 --- a/registry/factory.go +++ /dev/null @@ -1,7 +0,0 @@ -package registry - -import "github.com/dubbo/go-for-apache-dubbo/config" - -type RegistryFactory interface { - GetRegistry(url config.URL) Registry -} diff --git a/registry/registry.go b/registry/registry.go index e8711f7fc57c4c1b4940d630e92c0aad6c73014e..7b724daa2afbd904b93484a49a5dc75f6b3a10cc 100644 --- a/registry/registry.go +++ b/registry/registry.go @@ -14,13 +14,6 @@ type Registry interface { //used for service consumer ,start subscribe service event from registry Subscribe(config.URL) (Listener, error) - - //input the serviceConfig , registry should return serviceUrlArray with multi location(provider nodes) available - //GetService(SubURL) ([]SubURL, error) - //close the registry for Elegant closing - //Close() - //return if the registry is closed for consumer subscribing - //IsClosed() bool } type Listener interface { diff --git a/registry/zookeeper/zk_client.go b/registry/zookeeper/zk_client.go index 3c3524f9f53b95d438dd99d9f67fa69410f18c62..afd93496691fea3fef4efed19212686a7d400aaf 100644 --- a/registry/zookeeper/zk_client.go +++ b/registry/zookeeper/zk_client.go @@ -294,8 +294,8 @@ func (z *zookeeperClient) RegisterTemp(basePath string, node string) (string, er tmpPath, err = z.conn.Create(zkPath, data, zk.FlagEphemeral, zk.WorldACL(zk.PermAll)) } z.Unlock() - //if err != nil && err != zk.ErrNodeExists { - if err != nil { + if err != nil && err != zk.ErrNodeExists { + //if err != nil { log.Warn("conn.Create(\"%s\", zk.FlagEphemeral) = error(%v)\n", zkPath, jerrors.ErrorStack(err)) return "", jerrors.Trace(err) }