diff --git a/config_center/apollo/impl.go b/config_center/apollo/impl.go index d9c9ad2c301810148a0931c3667bc20d11ead822..1df3bedded5aa949ce21921b0edaf6931f8a1d6b 100644 --- a/config_center/apollo/impl.go +++ b/config_center/apollo/impl.go @@ -130,8 +130,7 @@ func (c *apolloConfiguration) GetRule(key string, opts ...cc.Option) (string, er // PublishConfig will publish the config with the (key, group, value) pair func (c *apolloConfiguration) PublishConfig(string, string, string) error { - // todo(@zouyx) - return nil + return errors.New("unsupport operation") } func (c *apolloConfiguration) GetProperties(key string, opts ...cc.Option) (string, error) { diff --git a/config_center/dynamic_configuration.go b/config_center/dynamic_configuration.go index e5284e89eb5bfade76378975338069de649dfcbb..e643e011fb0dfabef163153745b71afba31d5a7c 100644 --- a/config_center/dynamic_configuration.go +++ b/config_center/dynamic_configuration.go @@ -53,7 +53,6 @@ type DynamicConfiguration interface { // PublishConfig will publish the config with the (key, group, value) pair PublishConfig(string, string, string) error - } // Options ... diff --git a/config_center/nacos/impl.go b/config_center/nacos/impl.go index a1f9ff8cc65476ac6eb3381e01f8c0a43a3d8c68..752bec7fc98f6e83056efd52d8d52bb23f069036 100644 --- a/config_center/nacos/impl.go +++ b/config_center/nacos/impl.go @@ -18,7 +18,6 @@ package nacos import ( - "errors" "strings" "sync" ) @@ -92,16 +91,16 @@ func (nacos *nacosDynamicConfiguration) PublishConfig(key string, group string, group = nacos.resolvedGroup(group) ok, err := (*nacos.client.Client()).PublishConfig(vo.ConfigParam{ - DataId: key, - Group: group, - Content: value, + DataId: key, + Group: group, + Content: value, }) if err != nil { return err } if !ok { - return errors.New("publish config to Nocos failed") + return perrors.New("publish config to Nocos failed") } return nil } @@ -170,7 +169,7 @@ func (nacos *nacosDynamicConfiguration) Destroy() { // resolvedGroup will regular the group. Now, it will replace the '/' with '-'. // '/' is a special character for nacos func (nacos *nacosDynamicConfiguration) resolvedGroup(group string) string { - if len(group) <=0 { + if len(group) <= 0 { return group } return strings.ReplaceAll(group, "/", "-") diff --git a/config_center/zookeeper/impl.go b/config_center/zookeeper/impl.go index f8263e47c7f31035231e4b6f2ab805096addf2ff..38b0057d3a901d82ef83fbc78c8517ee48116754 100644 --- a/config_center/zookeeper/impl.go +++ b/config_center/zookeeper/impl.go @@ -40,7 +40,7 @@ import ( const ( // ZkClient //zookeeper client name - ZkClient = "zk config_center" + ZkClient = "zk config_center" pathSeparator = "/" ) @@ -228,7 +228,7 @@ func (c *zookeeperDynamicConfiguration) RestartCallBack() bool { func (c *zookeeperDynamicConfiguration) getPath(key string, group string) string { if len(key) <= 0 { - return c.buildPath(group) + return c.buildPath(group) } return c.buildPath(group) + pathSeparator + key } diff --git a/remoting/zookeeper/client.go b/remoting/zookeeper/client.go index 936b3b5acf39b103fbfcecd4bace4b6dbca8e944..aeb249b301a7b3db6473a5a3f3ceb2ff46763e73 100644 --- a/remoting/zookeeper/client.go +++ b/remoting/zookeeper/client.go @@ -431,8 +431,6 @@ func (z *ZookeeperClient) CreateWithValue(basePath string, value []byte) error { return nil } - - // Delete ... func (z *ZookeeperClient) Delete(basePath string) error { var (