From 16971dbb205e2a93a6e942a2379e166052199266 Mon Sep 17 00:00:00 2001
From: Joe Zou <yixian.zou@gmail.com>
Date: Sun, 12 Jul 2020 01:01:56 +0800
Subject: [PATCH] fix review comment

---
 .../subscribed_urls_synthesizer_factory.go            | 11 ++++++++++-
 1 file changed, 10 insertions(+), 1 deletion(-)

diff --git a/registry/servicediscovery/synthesizer/subscribed_urls_synthesizer_factory.go b/registry/servicediscovery/synthesizer/subscribed_urls_synthesizer_factory.go
index ba7887223..c9b1449be 100644
--- a/registry/servicediscovery/synthesizer/subscribed_urls_synthesizer_factory.go
+++ b/registry/servicediscovery/synthesizer/subscribed_urls_synthesizer_factory.go
@@ -17,16 +17,25 @@
 
 package synthesizer
 
+import (
+	"sync"
+)
+
 var (
-	synthesizers []SubscribedURLsSynthesizer
+	synthesizers     []SubscribedURLsSynthesizer
+	synthesizerMutex sync.RWMutex
 )
 
 // nolint
 func AddSynthesizer(synthesizer SubscribedURLsSynthesizer) {
+	synthesizerMutex.Lock()
+	defer synthesizerMutex.Unlock()
 	synthesizers = append(synthesizers, synthesizer)
 }
 
 // nolint
 func GetAllSynthesizer() []SubscribedURLsSynthesizer {
+	synthesizerMutex.RLock()
+	defer synthesizerMutex.RUnlock()
 	return synthesizers
 }
-- 
GitLab