diff --git a/cluster/router/conncheck/conn_check_route_test.go b/cluster/router/conncheck/conn_check_route_test.go index 5277b0870bcd726a0f2eacfe18702a2acffe4c84..edbc2cbeac190d3c5308ec2b5b90ce40acf30161 100644 --- a/cluster/router/conncheck/conn_check_route_test.go +++ b/cluster/router/conncheck/conn_check_route_test.go @@ -73,7 +73,6 @@ func TestConnCheckRouterRoute(t *testing.T) { // now invoker3 is healthy assert.True(t, len(res.ToArray()) == 1) - invoker2 = NewMockInvoker(url2) // check blacklist remove protocol.RemoveInvokerUnhealthyStatus(invoker1) diff --git a/cluster/router/conncheck/conn_health_check_test.go b/cluster/router/conncheck/conn_health_check_test.go index 7544014972819d24b30fa035524cb033a2f4846c..44d148e1b8c494cc48a04ba56f2175df8ceec19e 100644 --- a/cluster/router/conncheck/conn_health_check_test.go +++ b/cluster/router/conncheck/conn_health_check_test.go @@ -46,7 +46,6 @@ func TestDefaultConnCheckerIsHealthy(t *testing.T) { invoker = NewMockInvoker(url) cc = NewDefaultConnChecker(url).(*DefaultConnChecker) - healthy = cc.IsConnHealthy(invoker) // add to black list protocol.SetInvokerUnhealthyStatus(invoker) assert.False(t, cc.IsConnHealthy(invoker)) diff --git a/protocol/dubbo/dubbo_codec.go b/protocol/dubbo/dubbo_codec.go index f92da4aa7f164fce131f9f869f9550b6e7168943..21376c3145d7d620d7fc12f2bc67efcd65faee4b 100644 --- a/protocol/dubbo/dubbo_codec.go +++ b/protocol/dubbo/dubbo_codec.go @@ -105,7 +105,7 @@ func (c *DubboCodec) EncodeRequest(request *remoting.Request) (*bytes.Buffer, er return pkg.Marshal() } -// encode heartbeart request +// encode heartbeat request func (c *DubboCodec) encodeHeartbeartReqeust(request *remoting.Request) (*bytes.Buffer, error) { header := impl.DubboHeader{ Type: impl.PackageHeartbeat, diff --git a/protocol/grpc/protoc-gen-dubbo/main.go b/protocol/grpc/protoc-gen-dubbo/main.go index fbcfa6f9d492afa8bc7848c733358b3cf7223e99..fe3e38dddd8bfc2a30ed89e6088516cad120ef79 100644 --- a/protocol/grpc/protoc-gen-dubbo/main.go +++ b/protocol/grpc/protoc-gen-dubbo/main.go @@ -43,7 +43,7 @@ func main() { g.Error(err, "reading input") } - if err := proto.Unmarshal(data, g.Request); err != nil { + if err = proto.Unmarshal(data, g.Request); err != nil { g.Error(err, "parsing input proto") } diff --git a/remoting/getty/dubbo_codec_for_test.go b/remoting/getty/dubbo_codec_for_test.go index be6d9db07c681839485ddad65ce989d7235ec5af..9afc18a9aaf477588a2fbf051096494b6f887fa2 100644 --- a/remoting/getty/dubbo_codec_for_test.go +++ b/remoting/getty/dubbo_codec_for_test.go @@ -99,7 +99,7 @@ func (c *DubboTestCodec) EncodeRequest(request *remoting.Request) (*bytes.Buffer return pkg.Marshal() } -// encode heartbeart request +// encode heartbeat request func (c *DubboTestCodec) encodeHeartbeartReqeust(request *remoting.Request) (*bytes.Buffer, error) { header := impl.DubboHeader{ Type: impl.PackageHeartbeat, diff --git a/remoting/getty/listener.go b/remoting/getty/listener.go index b2f7790f2ffcab6832224e07219016cb46a3fa4d..a07726e5a609a40734946028f69de4d1653521a5 100644 --- a/remoting/getty/listener.go +++ b/remoting/getty/listener.go @@ -101,7 +101,7 @@ func (h *RpcClientHandler) OnMessage(session getty.Session, pkg interface{}) { logger.Errorf("illegal package") return } - // get heartbeart request from server + // get heartbeat request from server if result.IsRequest { req := result.Result.(*remoting.Request) if req.Event { @@ -252,7 +252,7 @@ func (h *RpcServerHandler) OnMessage(session getty.Session, pkg interface{}) { res.Handle() return } - logger.Errorf("illegal package but not heartbeart. {%#v}", pkg) + logger.Errorf("illegal package but not heartbeat. {%#v}", pkg) return } req := decodeResult.Result.(*remoting.Request)