diff --git a/common/rpc_service.go b/common/rpc_service.go index 3bb3dfe32250ee24e35b1f594509b477a4eea5c9..3a25d322391bf3ee52fabadd511677a52dcb169a 100644 --- a/common/rpc_service.go +++ b/common/rpc_service.go @@ -133,7 +133,7 @@ func (s *Service) Method() map[string]*MethodType { return s.methods } -// Method ... +// Name will return service name func (s *Service) Name() string { return s.name } diff --git a/config/base_config_test.go b/config/base_config_test.go index e06b68a9dc8b876162f889c28af9a9ac3bbd3484..60eccfb1836dccbec0e8dc593a0954005117c28e 100644 --- a/config/base_config_test.go +++ b/config/base_config_test.go @@ -53,15 +53,6 @@ func Test_refresh(t *testing.T) { Owner: "dubbo", Environment: "test"}, Registries: map[string]*RegistryConfig{ - //"shanghai_reg1": { - // id: "shanghai_reg1", - // Protocol: "mock", - // TimeoutStr: "2s", - // group: "shanghai_idc", - // Address: "127.0.0.1:2181", - // Username: "user1", - // Password: "pwd1", - //}, "shanghai_reg2": { Protocol: "mock", TimeoutStr: "2s", @@ -156,15 +147,6 @@ func Test_appExternal_refresh(t *testing.T) { Owner: "dubbo", Environment: "test"}, Registries: map[string]*RegistryConfig{ - //"shanghai_reg1": { - // id: "shanghai_reg1", - // Protocol: "mock", - // TimeoutStr: "2s", - // group: "shanghai_idc", - // Address: "127.0.0.1:2181", - // Username: "user1", - // Password: "pwd1", - //}, "shanghai_reg2": { Protocol: "mock", TimeoutStr: "2s", @@ -251,15 +233,6 @@ func Test_appExternalWithoutId_refresh(t *testing.T) { Owner: "dubbo", Environment: "test"}, Registries: map[string]*RegistryConfig{ - //"shanghai_reg1": { - // id: "shanghai_reg1", - // Protocol: "mock", - // TimeoutStr: "2s", - // group: "shanghai_idc", - // Address: "127.0.0.1:2181", - // Username: "user1", - // Password: "pwd1", - //}, "shanghai_reg2": { Protocol: "mock", TimeoutStr: "2s", @@ -408,15 +381,6 @@ func Test_refreshProvider(t *testing.T) { Owner: "dubbo", Environment: "test"}, Registries: map[string]*RegistryConfig{ - //"shanghai_reg1": { - // id: "shanghai_reg1", - // Protocol: "mock", - // TimeoutStr: "2s", - // group: "shanghai_idc", - // Address: "127.0.0.1:2181", - // Username: "user1", - // Password: "pwd1", - //}, "shanghai_reg2": { Protocol: "mock", TimeoutStr: "2s", diff --git a/config/instance/metedata_report.go b/config/instance/metedata_report.go index 6adc7e8a686c2308fa9c06c2aa3f2e393795fb0d..9cf435bc9debf09d0707d0a3b5d699c79d2cafa7 100644 --- a/config/instance/metedata_report.go +++ b/config/instance/metedata_report.go @@ -18,13 +18,13 @@ package instance import ( - "github.com/apache/dubbo-go/metadata/report" "sync" ) import ( "github.com/apache/dubbo-go/common" "github.com/apache/dubbo-go/common/extension" + "github.com/apache/dubbo-go/metadata/report" ) var ( diff --git a/config/service_config_test.go b/config/service_config_test.go index 26c558db1bfa44d116dbd9d946e90c43298d66ef..fb3b4a7dc20e32fbcaf6f9514991fba9a7af0d95 100644 --- a/config/service_config_test.go +++ b/config/service_config_test.go @@ -18,10 +18,13 @@ package config import ( - "go.uber.org/atomic" "testing" ) +import ( + "go.uber.org/atomic" +) + import ( "github.com/apache/dubbo-go/common/extension" ) diff --git a/config_center/zookeeper/impl_test.go b/config_center/zookeeper/impl_test.go index b8c2cf49d14817202c88782f7ffff2ddecb86c6e..30389122a3a06ee260f2ed8b21057523137995d5 100644 --- a/config_center/zookeeper/impl_test.go +++ b/config_center/zookeeper/impl_test.go @@ -159,7 +159,7 @@ func Test_RemoveListener(t *testing.T) { func TestZookeeperDynamicConfiguration_PublishConfig(t *testing.T) { value := "Test Data" - customGroup := "Custom group" + customGroup := "Custom Group" key := "myKey" ts, zk := initZkData(config_center.DEFAULT_GROUP, t) defer ts.Stop() diff --git a/metadata/namemapping/dynamic/service_name_mapping.go b/metadata/namemapping/dynamic/service_name_mapping.go index b50a73c820589d7f1b10a35310201ac79de3b481..85e94a89c72be2237b52b1c96329435371be2279 100644 --- a/metadata/namemapping/dynamic/service_name_mapping.go +++ b/metadata/namemapping/dynamic/service_name_mapping.go @@ -18,7 +18,6 @@ package dynamic import ( - "github.com/apache/dubbo-go/metadata/namemapping" "strconv" "time" ) @@ -32,6 +31,7 @@ import ( "github.com/apache/dubbo-go/common/constant" "github.com/apache/dubbo-go/config" "github.com/apache/dubbo-go/config_center" + "github.com/apache/dubbo-go/metadata/namemapping" ) const (