From 94414e4bde392a22f4f7ed0983df4cc992aa643a Mon Sep 17 00:00:00 2001
From: Joe Zou <yixian.zou@gmail.com>
Date: Tue, 28 Apr 2020 18:04:00 +0800
Subject: [PATCH] fix review comments
---
config/service_config.go | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/config/service_config.go b/config/service_config.go
index ffacd2017..45e7df630 100644
--- a/config/service_config.go
+++ b/config/service_config.go
@@ -116,12 +116,10 @@ func getRandomPort(protocolConfigs []*ProtocolConfig) *list.List {
}
tcp, err := gxnet.ListenOnTCPRandomPort(proto.Ip)
- if tcp != nil {
- defer tcp.Close()
- }
if err != nil {
panic(perrors.New(fmt.Sprintf("Get tcp port error,err is {%v}", err)))
}
+ defer tcp.Close()
ports.PushBack(strings.Split(tcp.Addr().String(), ":")[1])
}
return ports
--
GitLab