From b9822bdffe533ddf9f9e54c3278d95fbb2cacd8a Mon Sep 17 00:00:00 2001
From: Joe Zou <yixian.zou@gmail.com>
Date: Fri, 8 Nov 2019 22:49:22 +0800
Subject: [PATCH] fix review problems
---
config_center/apollo/factory.go | 5 ++++-
config_center/apollo/impl_test.go | 8 ++++----
config_center/apollo/listener.go | 4 ++--
3 files changed, 10 insertions(+), 7 deletions(-)
diff --git a/config_center/apollo/factory.go b/config_center/apollo/factory.go
index 76a99ca28..c7673f811 100644
--- a/config_center/apollo/factory.go
+++ b/config_center/apollo/factory.go
@@ -18,10 +18,13 @@ limitations under the License.
package apollo
import (
- "github.com/apache/dubbo-go/config_center/parser"
"sync"
)
+import (
+ "github.com/apache/dubbo-go/config_center/parser"
+)
+
import (
"github.com/apache/dubbo-go/common"
"github.com/apache/dubbo-go/common/extension"
diff --git a/config_center/apollo/impl_test.go b/config_center/apollo/impl_test.go
index c5d8b76a6..52ab60f06 100644
--- a/config_center/apollo/impl_test.go
+++ b/config_center/apollo/impl_test.go
@@ -26,6 +26,10 @@ import (
"testing"
)
+import (
+ "github.com/stretchr/testify/assert"
+)
+
import (
"github.com/apache/dubbo-go/common"
"github.com/apache/dubbo-go/config"
@@ -34,10 +38,6 @@ import (
"github.com/apache/dubbo-go/remoting"
)
-import (
- "github.com/stretchr/testify/assert"
-)
-
const (
mockAppId = "testApplication_yang"
mockCluster = "dev"
diff --git a/config_center/apollo/listener.go b/config_center/apollo/listener.go
index 33f049150..d81e1cbf3 100644
--- a/config_center/apollo/listener.go
+++ b/config_center/apollo/listener.go
@@ -18,11 +18,11 @@ limitations under the License.
package apollo
import (
- "github.com/apache/dubbo-go/config_center"
+ "github.com/zouyx/agollo"
)
import (
- "github.com/zouyx/agollo"
+ "github.com/apache/dubbo-go/config_center"
)
type apolloListener struct {
--
GitLab