From bcac1db16a7a5957bfcd9ae9ca2b33c1e6c68eca Mon Sep 17 00:00:00 2001
From: Joe Zou <yixian.zou@gmail.com>
Date: Sat, 16 May 2020 14:13:18 +0800
Subject: [PATCH] add comment and test case
---
registry/zookeeper/registry_test.go | 7 +++++++
remoting/zookeeper/listener.go | 2 +-
2 files changed, 8 insertions(+), 1 deletion(-)
diff --git a/registry/zookeeper/registry_test.go b/registry/zookeeper/registry_test.go
index b7451f954..d4141e801 100644
--- a/registry/zookeeper/registry_test.go
+++ b/registry/zookeeper/registry_test.go
@@ -61,6 +61,13 @@ func Test_UnRegister(t *testing.T) {
children, err = reg.client.GetChildren("/dubbo/com.ikurento.user.UserProvider/providers")
assert.Equal(t, 0, len(children))
assert.Error(t, err)
+ assert.True(t, reg.IsAvailable())
+
+ err = reg.Register(url)
+ children, _ = reg.client.GetChildren("/dubbo/com.ikurento.user.UserProvider/providers")
+ assert.Regexp(t, ".*dubbo%3A%2F%2F127.0.0.1%3A20000%2Fcom.ikurento.user.UserProvider%3Fanyhost%3Dtrue%26cluster%3Dmock%26.*.serviceid%3Dsoa.mock", children)
+ assert.NoError(t, err)
+
}
func Test_Subscribe(t *testing.T) {
diff --git a/remoting/zookeeper/listener.go b/remoting/zookeeper/listener.go
index 6c9d07238..097106acf 100644
--- a/remoting/zookeeper/listener.go
+++ b/remoting/zookeeper/listener.go
@@ -314,7 +314,7 @@ func (l *ZkEventListener) valid() bool {
return l.client.ZkConnValid()
}
-// Close ...
+// Close will let client listen exit
func (l *ZkEventListener) Close() {
close(l.client.exit)
l.wg.Wait()
--
GitLab