From bfbe4e9ce2f44d812f00a9002b8afdbc053abdc9 Mon Sep 17 00:00:00 2001
From: cvictory <shenglicao2@gmail.com>
Date: Sun, 17 Jan 2021 20:27:52 +0800
Subject: [PATCH] fix review issue
---
common/extension/metadata_service.go | 2 +-
metadata/service/remote/service.go | 5 ++---
registry/servicediscovery/service_discovery_registry.go | 4 ----
3 files changed, 3 insertions(+), 8 deletions(-)
diff --git a/common/extension/metadata_service.go b/common/extension/metadata_service.go
index cf8b286c6..08ddbc333 100644
--- a/common/extension/metadata_service.go
+++ b/common/extension/metadata_service.go
@@ -62,6 +62,6 @@ func GetRemoteMetadataService() (service.MetadataService, error) {
remoteMetadataService, err = creator()
return remoteMetadataService, err
}
- logger.Info("could not find the metadata service creator for metadataType: remote")
+ logger.Warn("could not find the metadata service creator for metadataType: remote")
return nil, perrors.New(fmt.Sprintf("could not find the metadata service creator for metadataType: remote"))
}
diff --git a/metadata/service/remote/service.go b/metadata/service/remote/service.go
index 1ad246314..c72d02e33 100644
--- a/metadata/service/remote/service.go
+++ b/metadata/service/remote/service.go
@@ -124,9 +124,8 @@ func (mts *MetadataService) PublishServiceDefinition(url *common.URL) error {
BaseMetadataIdentifier: identifier.BaseMetadataIdentifier{
ServiceInterface: interfaceName,
Version: url.GetParam(constant.VERSION_KEY, ""),
- // Group: url.GetParam(constant.GROUP_KEY, constant.SERVICE_DISCOVERY_DEFAULT_GROUP),
- Group: url.GetParam(constant.GROUP_KEY, constant.DUBBO),
- Side: url.GetParam(constant.SIDE_KEY, "provider"),
+ Group: url.GetParam(constant.GROUP_KEY, constant.DUBBO),
+ Side: url.GetParam(constant.SIDE_KEY, "provider"),
},
}
mts.delegateReport.StoreProviderMetadata(id, sd)
diff --git a/registry/servicediscovery/service_discovery_registry.go b/registry/servicediscovery/service_discovery_registry.go
index 2ca4b8015..c97a7f7b5 100644
--- a/registry/servicediscovery/service_discovery_registry.go
+++ b/registry/servicediscovery/service_discovery_registry.go
@@ -174,10 +174,6 @@ func (s *serviceDiscoveryRegistry) Register(url *common.URL) error {
logger.Warnf("The URL[%s] has been registry!", url.String())
}
- err = s.metaDataService.PublishServiceDefinition(url)
- if err != nil {
- return perrors.WithMessage(err, "publish the service definition failed. ")
- }
return s.serviceNameMapping.Map(url.GetParam(constant.INTERFACE_KEY, ""),
url.GetParam(constant.GROUP_KEY, ""),
url.GetParam(constant.Version, ""),
--
GitLab