From c312cc8588f8a5c0f5bb3fb63b60a04d2e95652f Mon Sep 17 00:00:00 2001 From: "vito.he" <hxmhlt@163.com> Date: Sat, 23 May 2020 23:55:51 +0800 Subject: [PATCH] Mod:modify for code review --- metadata/definition/definition.go | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/metadata/definition/definition.go b/metadata/definition/definition.go index 11e137a14..c8dd86b18 100644 --- a/metadata/definition/definition.go +++ b/metadata/definition/definition.go @@ -29,7 +29,7 @@ import ( "github.com/apache/dubbo-go/common/constant" ) -// ServiceDefinition is a interface of service's definition +// ServiceDefiner is a interface of service's definition type ServiceDefiner interface { ToBytes() ([]byte, error) } @@ -42,11 +42,11 @@ type ServiceDefinition struct { Types []TypeDefinition } -func (def ServiceDefinition) ToBytes() ([]byte, error) { +func (def *ServiceDefinition) ToBytes() ([]byte, error) { return json.Marshal(def) } -func (def ServiceDefinition) String() string { +func (def *ServiceDefinition) String() string { var methodStr strings.Builder for _, m := range def.Methods { var paramType strings.Builder -- GitLab