From d452e5c4d0207ecc93ac9a4d155d25a8375003f4 Mon Sep 17 00:00:00 2001
From: Joe Zou <yixian.zou@gmail.com>
Date: Wed, 22 Jul 2020 10:39:37 +0800
Subject: [PATCH] fix review comment
---
config_center/apollo/listener.go | 4 ++--
go.mod | 2 +-
go.sum | 4 ++--
3 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/config_center/apollo/listener.go b/config_center/apollo/listener.go
index 4d28b9969..33afbc5d8 100644
--- a/config_center/apollo/listener.go
+++ b/config_center/apollo/listener.go
@@ -33,7 +33,7 @@ type apolloListener struct {
listeners map[config_center.ConfigurationListener]struct{}
}
-// newApolloListener ...
+// nolint
func newApolloListener() *apolloListener {
return &apolloListener{
listeners: make(map[config_center.ConfigurationListener]struct{}, 0),
@@ -45,7 +45,7 @@ func (a *apolloListener) OnChange(changeEvent *storage.ChangeEvent) {
}
-// OnNewestChange ...
+// OnNewestChange process each listener by all changes
func (a *apolloListener) OnNewestChange(changeEvent *storage.FullChangeEvent) {
b, err := yaml.Marshal(changeEvent.Changes)
if err != nil {
diff --git a/go.mod b/go.mod
index 283014421..038d23879 100644
--- a/go.mod
+++ b/go.mod
@@ -30,7 +30,7 @@ require (
github.com/prometheus/client_golang v1.1.0
github.com/satori/go.uuid v1.2.1-0.20181028125025-b2ce2384e17b
github.com/stretchr/testify v1.5.1
- github.com/zouyx/agollo/v3 v3.4.3
+ github.com/zouyx/agollo/v3 v3.4.4
go.etcd.io/bbolt v1.3.3 // indirect
go.etcd.io/etcd v3.3.13+incompatible
go.uber.org/atomic v1.4.0
diff --git a/go.sum b/go.sum
index 1b1494b78..ce9d4e1f3 100644
--- a/go.sum
+++ b/go.sum
@@ -554,8 +554,8 @@ github.com/vmware/govmomi v0.18.0 h1:f7QxSmP7meCtoAmiKZogvVbLInT+CZx6Px6K5rYsJZo
github.com/vmware/govmomi v0.18.0/go.mod h1:URlwyTFZX72RmxtxuaFL2Uj3fD1JTvZdx59bHWk6aFU=
github.com/xiang90/probing v0.0.0-20190116061207-43a291ad63a2 h1:eY9dn8+vbi4tKz5Qo6v2eYzo7kUS51QINcR5jNpbZS8=
github.com/xiang90/probing v0.0.0-20190116061207-43a291ad63a2/go.mod h1:UETIi67q53MR2AWcXfiuqkDkRtnGDLqkBTpCHuJHxtU=
-github.com/zouyx/agollo/v3 v3.4.3 h1:1Ni6VbcwMkEyJBNOk8ApRSAuh42YsnYuhW79lNE+TBA=
-github.com/zouyx/agollo/v3 v3.4.3/go.mod h1:ag0XmE1r4iAgPd6PUnU9TJ0DMEjM1VKX1HUNqQJ2ywU=
+github.com/zouyx/agollo/v3 v3.4.4 h1:5G7QNw3fw74Ns8SfnHNhjndV2mlz5Fg8bB7q84ydFYI=
+github.com/zouyx/agollo/v3 v3.4.4/go.mod h1:ag0XmE1r4iAgPd6PUnU9TJ0DMEjM1VKX1HUNqQJ2ywU=
go.etcd.io/bbolt v1.3.2/go.mod h1:IbVyRI1SCnLcuJnV2u8VeU0CEYM7e686BmAb1XKL+uU=
go.etcd.io/bbolt v1.3.3 h1:MUGmc65QhB3pIlaQ5bB4LwqSj6GIonVJXpZiaKNyaKk=
go.etcd.io/bbolt v1.3.3/go.mod h1:IbVyRI1SCnLcuJnV2u8VeU0CEYM7e686BmAb1XKL+uU=
--
GitLab