diff --git a/common/url.go b/common/url.go index 4fd0ac3f7ea30747948ce2fb4c75ed6460f359a6..fadec7acf0ebb2b4dc4e816502b1b1697ba0e9bc 100644 --- a/common/url.go +++ b/common/url.go @@ -313,7 +313,7 @@ func (c *URL) GetBackupUrls() []*URL { WithUsername(c.Username), WithPassword(c.Password), WithPort(port), - WithParams(c.Params)) + WithParams(c.params)) urls = append(urls, newURL) } diff --git a/config/condition_router_config.go b/config/condition_router_config.go index 77ab227cecb37b2d37434b8b0db294b1f8735751..41af2a9cf9f5b673dbbc53b1602d3d853c8016ed 100644 --- a/config/condition_router_config.go +++ b/config/condition_router_config.go @@ -18,7 +18,6 @@ package config import ( "encoding/base64" - "fmt" "io/ioutil" "net/url" "os" diff --git a/config_center/dynamic_configuration.go b/config_center/dynamic_configuration.go index 1efac15781f8cc720c9cd083801be92b1e707bdc..0546d39732deaa83ace948275a0d4448b1b24cf8 100644 --- a/config_center/dynamic_configuration.go +++ b/config_center/dynamic_configuration.go @@ -44,10 +44,6 @@ type DynamicConfiguration interface { //GetInternalProperty get value by key in Default properties file(dubbo.properties) GetInternalProperty(string, ...Option) (string, error) - - GetConfig(string, ...Option) (string, error) - SetConfig(string, string, string) error - GetConfigs(string, ...Option) (string, error) } type Options struct { diff --git a/config_center/mock_dynamic_config.go b/config_center/mock_dynamic_config.go index 7cc758cc14947ddfc543a74c91c90ffbd2fcf662..dd1610f06f6871f311fbb44b32a4079ec2b336bd 100644 --- a/config_center/mock_dynamic_config.go +++ b/config_center/mock_dynamic_config.go @@ -97,15 +97,6 @@ func (c *MockDynamicConfiguration) GetConfig(key string, opts ...Option) (string return c.content, nil } -func (c *mockDynamicConfiguration) SetConfig(group string, key string, value string) error { - return nil -} - -//For zookeeper, getConfig and getConfigs have the same meaning. -func (c *MockDynamicConfiguration) GetConfigs(key string, opts ...Option) (string, error) { - return c.GetConfig(key, opts...) -} - func (c *MockDynamicConfiguration) Parser() parser.ConfigurationParser { return c.parser } diff --git a/registry/directory/directory_test.go b/registry/directory/directory_test.go index 973443901e6bb0fe9170342db7fcfeea7ed04dec..e9f62dc5641dc99aa678e4e74ea6e77185d944ad 100644 --- a/registry/directory/directory_test.go +++ b/registry/directory/directory_test.go @@ -118,7 +118,7 @@ func Test_List(t *testing.T) { registryDirectory, _ := normalRegistryDir() time.Sleep(1e9) - invokers, _ := registryDirectory.List(&invocation.RPCInvocation{}) + invokers := registryDirectory.List(&invocation.RPCInvocation{}) assert.Len(t, invokers, 3) assert.Equal(t, true, registryDirectory.IsAvailable())