From e5bee952fa7aad8cc4aecf0e87ce0addf78df1af Mon Sep 17 00:00:00 2001
From: LaurenceLiZhixin <382673304@qq.com>
Date: Thu, 7 Jan 2021 19:17:39 +0800
Subject: [PATCH] fix: lint
---
cluster/router/conncheck/conn_check_route_test.go | 1 -
cluster/router/conncheck/conn_health_check_test.go | 1 -
protocol/dubbo/dubbo_codec.go | 2 +-
protocol/grpc/protoc-gen-dubbo/main.go | 2 +-
remoting/getty/dubbo_codec_for_test.go | 2 +-
remoting/getty/listener.go | 4 ++--
6 files changed, 5 insertions(+), 7 deletions(-)
diff --git a/cluster/router/conncheck/conn_check_route_test.go b/cluster/router/conncheck/conn_check_route_test.go
index 5277b0870..edbc2cbea 100644
--- a/cluster/router/conncheck/conn_check_route_test.go
+++ b/cluster/router/conncheck/conn_check_route_test.go
@@ -73,7 +73,6 @@ func TestConnCheckRouterRoute(t *testing.T) {
// now invoker3 is healthy
assert.True(t, len(res.ToArray()) == 1)
- invoker2 = NewMockInvoker(url2)
// check blacklist remove
protocol.RemoveInvokerUnhealthyStatus(invoker1)
diff --git a/cluster/router/conncheck/conn_health_check_test.go b/cluster/router/conncheck/conn_health_check_test.go
index 754401497..44d148e1b 100644
--- a/cluster/router/conncheck/conn_health_check_test.go
+++ b/cluster/router/conncheck/conn_health_check_test.go
@@ -46,7 +46,6 @@ func TestDefaultConnCheckerIsHealthy(t *testing.T) {
invoker = NewMockInvoker(url)
cc = NewDefaultConnChecker(url).(*DefaultConnChecker)
- healthy = cc.IsConnHealthy(invoker)
// add to black list
protocol.SetInvokerUnhealthyStatus(invoker)
assert.False(t, cc.IsConnHealthy(invoker))
diff --git a/protocol/dubbo/dubbo_codec.go b/protocol/dubbo/dubbo_codec.go
index f92da4aa7..21376c314 100644
--- a/protocol/dubbo/dubbo_codec.go
+++ b/protocol/dubbo/dubbo_codec.go
@@ -105,7 +105,7 @@ func (c *DubboCodec) EncodeRequest(request *remoting.Request) (*bytes.Buffer, er
return pkg.Marshal()
}
-// encode heartbeart request
+// encode heartbeat request
func (c *DubboCodec) encodeHeartbeartReqeust(request *remoting.Request) (*bytes.Buffer, error) {
header := impl.DubboHeader{
Type: impl.PackageHeartbeat,
diff --git a/protocol/grpc/protoc-gen-dubbo/main.go b/protocol/grpc/protoc-gen-dubbo/main.go
index fbcfa6f9d..fe3e38ddd 100644
--- a/protocol/grpc/protoc-gen-dubbo/main.go
+++ b/protocol/grpc/protoc-gen-dubbo/main.go
@@ -43,7 +43,7 @@ func main() {
g.Error(err, "reading input")
}
- if err := proto.Unmarshal(data, g.Request); err != nil {
+ if err = proto.Unmarshal(data, g.Request); err != nil {
g.Error(err, "parsing input proto")
}
diff --git a/remoting/getty/dubbo_codec_for_test.go b/remoting/getty/dubbo_codec_for_test.go
index be6d9db07..9afc18a9a 100644
--- a/remoting/getty/dubbo_codec_for_test.go
+++ b/remoting/getty/dubbo_codec_for_test.go
@@ -99,7 +99,7 @@ func (c *DubboTestCodec) EncodeRequest(request *remoting.Request) (*bytes.Buffer
return pkg.Marshal()
}
-// encode heartbeart request
+// encode heartbeat request
func (c *DubboTestCodec) encodeHeartbeartReqeust(request *remoting.Request) (*bytes.Buffer, error) {
header := impl.DubboHeader{
Type: impl.PackageHeartbeat,
diff --git a/remoting/getty/listener.go b/remoting/getty/listener.go
index b2f7790f2..a07726e5a 100644
--- a/remoting/getty/listener.go
+++ b/remoting/getty/listener.go
@@ -101,7 +101,7 @@ func (h *RpcClientHandler) OnMessage(session getty.Session, pkg interface{}) {
logger.Errorf("illegal package")
return
}
- // get heartbeart request from server
+ // get heartbeat request from server
if result.IsRequest {
req := result.Result.(*remoting.Request)
if req.Event {
@@ -252,7 +252,7 @@ func (h *RpcServerHandler) OnMessage(session getty.Session, pkg interface{}) {
res.Handle()
return
}
- logger.Errorf("illegal package but not heartbeart. {%#v}", pkg)
+ logger.Errorf("illegal package but not heartbeat. {%#v}", pkg)
return
}
req := decodeResult.Result.(*remoting.Request)
--
GitLab