Skip to content
Snippets Groups Projects
Select Git revision
13 results Searching

22b970497

  • Clone with SSH
  • Clone with HTTPS
  • user avatar
    Ming Lei authored and Jens Axboe committed
    Dispatch may still be in-progress after queue is frozen, so we have to
    quiesce queue before switching IO scheduler and updating nr_requests.
    
    Also when switching io schedulers, blk_mq_run_hw_queue() may still be
    called somewhere(such as from nvme_reset_work()), and io scheduler's
    per-hctx data may not be setup yet, so cause oops even inside
    blk_mq_hctx_has_pending(), such as it can be run just between:
    
            ret = e->ops.mq.init_sched(q, e);
    AND
            ret = e->ops.mq.init_hctx(hctx, i)
    
    inside blk_mq_init_sched().
    
    This reverts commit 7a148c2f(block: don't call blk_mq_quiesce_queue()
    after queue is frozen) basically, and makes sure blk_mq_hctx_has_pending
    won't be called if queue is quiesced.
    
    Reviewed-by: default avatarChristoph Hellwig <hch@lst.de>
    Fixes: 7a148c2f(block: don't call blk_mq_quiesce_queue() after queue is frozen)
    Reported-by: default avatarYi Zhang <yi.zhang@redhat.com>
    Tested-by: default avatarYi Zhang <yi.zhang@redhat.com>
    Signed-off-by: default avatarMing Lei <ming.lei@redhat.com>
    Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
    24f5a90f
    History
    Name Last commit Last update