Update doc: node api

Signed-off-by: GuoRentong <rentong.guo@zilliz.com>

.devcontainer.json

@@ -2,7 +2,7 @@
     "name": "Milvus Distributed Dev Container Definition",
     "dockerComposeFile": ["./docker-compose-vscode.yml"],
     "service": "ubuntu",
-    "initializeCommand": "scripts/init_devcontainer.sh && docker-compose -f docker-compose-vscode.yml down || true",
+    "initializeCommand": "scripts/init_devcontainer.sh && docker-compose -f docker-compose-vscode.yml down || true && docker-compose -f docker-compose-vscode.yml pull --ignore-pull-failures ubuntu",
     "workspaceFolder": "/go/src/github.com/zilliztech/milvus-distributed",
     "shutdownAction": "stopCompose",
     "extensions": [

.gitignore

@@ -11,7 +11,7 @@ pulsar/client-cpp/build/*
 # vscode generated files
 .vscode
 docker-compose-vscode.yml
-docker-compose-vscode.yml.tmp
+docker-compose-vscode.yml.bak
 
 cmake-build-debug
 cmake-build-release

.jenkins/modules/Build/Build.groovy

 timeout(time: 20, unit: 'MINUTES') {
-
-    sh '. ./scripts/before-install.sh && unset http_proxy && unset https_proxy && ./scripts/check_cache.sh -l $CCACHE_ARTFACTORY_URL --cache_dir=\$CCACHE_DIR -f ccache-\$OS_NAME-\$BUILD_ENV_IMAGE_ID.tar.gz || echo \"Ccache artfactory files not found!\"'
-    sh '. ./scripts/before-install.sh && unset http_proxy && unset https_proxy && ./scripts/check_cache.sh -l $GO_CACHE_ARTFACTORY_URL --cache_dir=\$(go env GOCACHE) -f go-cache-\$OS_NAME-\$BUILD_ENV_IMAGE_ID.tar.gz || echo \"Go cache artfactory files not found!\"'
-    sh '. ./scripts/before-install.sh && unset http_proxy && unset https_proxy && ./scripts/check_cache.sh -l $THIRDPARTY_ARTFACTORY_URL --cache_dir=$CUSTOM_THIRDPARTY_PATH -f thirdparty-download.tar.gz || echo \"Thirdparty artfactory files not found!\"'
-    sh '. ./scripts/before-install.sh && unset http_proxy && unset https_proxy && ./scripts/check_cache.sh -l $GO_MOD_ARTFACTORY_URL --cache_dir=\$GOPATH/pkg/mod -f milvus-distributed-go-mod-\$(md5sum go.mod).tar.gz || echo \"Go mod artfactory files not found!\"'
+    dir ("scripts") {
+        sh '. ./before-install.sh && unset http_proxy && unset https_proxy && ./check_cache.sh -l $CCACHE_ARTFACTORY_URL --cache_dir=\$CCACHE_DIR -f ccache-\$OS_NAME-\$BUILD_ENV_IMAGE_ID.tar.gz || echo \"Ccache artfactory files not found!\"'
+        sh '. ./before-install.sh && unset http_proxy && unset https_proxy && ./check_cache.sh -l $GO_CACHE_ARTFACTORY_URL --cache_dir=\$(go env GOCACHE) -f go-cache-\$OS_NAME-\$BUILD_ENV_IMAGE_ID.tar.gz || echo \"Go cache artfactory files not found!\"'
+        sh '. ./before-install.sh && unset http_proxy && unset https_proxy && ./check_cache.sh -l $THIRDPARTY_ARTFACTORY_URL --cache_dir=$CUSTOM_THIRDPARTY_PATH -f thirdparty-download.tar.gz || echo \"Thirdparty artfactory files not found!\"'
+        sh '. ./before-install.sh && unset http_proxy && unset https_proxy && ./check_cache.sh -l $GO_MOD_ARTFACTORY_URL --cache_dir=\$GOPATH/pkg/mod -f milvus-distributed-go-mod-cache.tar.gz || echo \"Go mod artfactory files not found!\"'
+    }
 
     // Zero the cache statistics (but not the configuration options)
     sh 'ccache -z'
     sh '. ./scripts/before-install.sh && make install'
     sh 'echo -e "===\n=== ccache statistics after build\n===" && ccache --show-stats'
 
-
-    withCredentials([usernamePassword(credentialsId: "${env.JFROG_CREDENTIALS_ID}", usernameVariable: 'USERNAME', passwordVariable: 'PASSWORD')]) {
-        sh '. ./scripts/before-install.sh && unset http_proxy && unset https_proxy && ./scripts/update_cache.sh -l $CCACHE_ARTFACTORY_URL --cache_dir=\$CCACHE_DIR -f ccache-\$OS_NAME-\$BUILD_ENV_IMAGE_ID.tar.gz -u ${USERNAME} -p ${PASSWORD}'
-        sh '. ./scripts/before-install.sh && unset http_proxy && unset https_proxy && ./scripts/update_cache.sh -l $GO_CACHE_ARTFACTORY_URL --cache_dir=\$(go env GOCACHE) -f go-cache-\$OS_NAME-\$BUILD_ENV_IMAGE_ID.tar.gz -u ${USERNAME} -p ${PASSWORD}'
-        sh '. ./scripts/before-install.sh && unset http_proxy && unset https_proxy && ./scripts/update_cache.sh -l $THIRDPARTY_ARTFACTORY_URL --cache_dir=$CUSTOM_THIRDPARTY_PATH -f thirdparty-download.tar.gz -u ${USERNAME} -p ${PASSWORD}'
-        sh '. ./scripts/before-install.sh && unset http_proxy && unset https_proxy && ./scripts/update_cache.sh -l $GO_MOD_ARTFACTORY_URL --cache_dir=\$GOPATH/pkg/mod -f milvus-distributed-go-mod-\$(md5sum go.mod).tar.gz -u ${USERNAME} -p ${PASSWORD}'
+    dir ("scripts") {
+        withCredentials([usernamePassword(credentialsId: "${env.JFROG_CREDENTIALS_ID}", usernameVariable: 'USERNAME', passwordVariable: 'PASSWORD')]) {
+            sh '. ./before-install.sh && unset http_proxy && unset https_proxy && ./update_cache.sh -l $CCACHE_ARTFACTORY_URL --cache_dir=\$CCACHE_DIR -f ccache-\$OS_NAME-\$BUILD_ENV_IMAGE_ID.tar.gz -u ${USERNAME} -p ${PASSWORD}'
+            sh '. ./before-install.sh && unset http_proxy && unset https_proxy && ./update_cache.sh -l $GO_CACHE_ARTFACTORY_URL --cache_dir=\$(go env GOCACHE) -f go-cache-\$OS_NAME-\$BUILD_ENV_IMAGE_ID.tar.gz -u ${USERNAME} -p ${PASSWORD}'
+            sh '. ./before-install.sh && unset http_proxy && unset https_proxy && ./update_cache.sh -l $THIRDPARTY_ARTFACTORY_URL --cache_dir=$CUSTOM_THIRDPARTY_PATH -f thirdparty-download.tar.gz -u ${USERNAME} -p ${PASSWORD}'
+            sh '. ./before-install.sh && unset http_proxy && unset https_proxy && ./update_cache.sh -l $GO_MOD_ARTFACTORY_URL --cache_dir=\$GOPATH/pkg/mod -f milvus-distributed-go-mod-cache.tar.gz -u ${USERNAME} -p ${PASSWORD}'
+        }
     }
 }

Makefile

@@ -76,7 +76,7 @@ else
 	@${GOPATH}/bin/ruleguard -rules ruleguard.rules.go ./tests/go/...
 endif
 
-verifiers: getdeps cppcheck fmt static-check
+verifiers: getdeps cppcheck fmt static-check ruleguard
 
 # Builds various components locally.
 build-go: build-cpp
@@ -127,6 +127,7 @@ install: all
 	@mkdir -p $(GOPATH)/bin && cp -f $(PWD)/bin/master $(GOPATH)/bin/master
 	@mkdir -p $(GOPATH)/bin && cp -f $(PWD)/bin/proxy $(GOPATH)/bin/proxy
 	@mkdir -p $(GOPATH)/bin && cp -f $(PWD)/bin/writenode $(GOPATH)/bin/writenode
+	@mkdir -p $(GOPATH)/bin && cp -f $(PWD)/bin/indexbuilder $(GOPATH)/bin/indexbuilder
 	@mkdir -p $(LIBRARY_PATH) && cp -f $(PWD)/internal/core/output/lib/* $(LIBRARY_PATH)
 	@echo "Installation successful."
 
@@ -134,7 +135,10 @@ clean:
 	@echo "Cleaning up all the generated files"
 	@find . -name '*.test' | xargs rm -fv
 	@find . -name '*~' | xargs rm -fv
-	@rm -rvf querynode
-	@rm -rvf master
-	@rm -rvf proxy
-	@rm -rvf writenode
+	@rm -rf bin/
+	@rm -rf lib/
+	@rm -rf $(GOPATH)/bin/master
+	@rm -rf $(GOPATH)/bin/proxy
+	@rm -rf $(GOPATH)/bin/querynode
+	@rm -rf $(GOPATH)/bin/writenode
+	@rm -rf $(GOPATH)/bin/indexbuilder

build/docker/deploy/.env

@@ -6,4 +6,4 @@ PULSAR_ADDRESS=pulsar://pulsar:6650
 ETCD_ADDRESS=etcd:2379
 MASTER_ADDRESS=master:53100
 MINIO_ADDRESS=minio:9000
-INDEX_BUILDER_ADDRESS=indexbuilder:31000
+INDEX_BUILDER_ADDRESS=indexbuider:31000

build/docker/deploy/indexbuilder/DockerFile

@@ -9,31 +9,12 @@
 # is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express
 # or implied. See the License for the specific language governing permissions and limitations under the License.
 
-FROM milvusdb/milvus-distributed-dev:amd64-ubuntu18.04-latest AS openblas
-
-#FROM alpine
-FROM ubuntu:bionic-20200921
-
-RUN apt-get update && apt-get install -y --no-install-recommends libtbb-dev gfortran
-
-#RUN echo "http://dl-cdn.alpinelinux.org/alpine/edge/testing" >> /etc/apk/repositories
-
-#RUN sed -i "s/dl-cdn.alpinelinux.org/mirrors.aliyun.com/g" /etc/apk/repositories \
-#      && apk add --no-cache libtbb gfortran
-
-COPY --from=openblas /usr/lib/libopenblas-r0.3.9.so /usr/lib/
-
-RUN ln -s /usr/lib/libopenblas-r0.3.9.so /usr/lib/libopenblas.so.0 && \
-    ln -s /usr/lib/libopenblas.so.0 /usr/lib/libopenblas.so
+FROM alpine:3.12.1
 
 COPY ./bin/indexbuilder /milvus-distributed/bin/indexbuilder
 
 COPY ./configs/ /milvus-distributed/configs/
 
-COPY ./lib/ /milvus-distributed/lib/
-
-ENV LD_LIBRARY_PATH=/milvus-distributed/lib:$LD_LIBRARY_PATH:/usr/lib
-
 WORKDIR /milvus-distributed/
 
 CMD ["./bin/indexbuilder"]

deployments/docker/docker-compose.yml

@@ -36,6 +36,14 @@ services:
     networks:
       - milvus
 
+  jaeger:
+    image: jaegertracing/all-in-one:latest
+    ports:
+      - "6831:6831/udp"
+      - "16686:16686"
+    networks:
+      - milvus
+
 networks:
   milvus:
 

docker-compose.yml

@@ -86,5 +86,10 @@ services:
     networks:
       - milvus
 
+  jaeger:
+    image: jaegertracing/all-in-one:latest
+    networks:
+      - milvus
+
 networks:
   milvus:

docs/developer_guides/chap03_index_builder.md → docs/developer_guides/chap03_index_service.md

@@ -65,3 +65,19 @@ type IndexFilePaths struct {
 }
 ```
 
+
+
+#### 8.3 Index Node
+
+```go
+type IndexNode interface {
+  Start() error
+  Close() error
+  
+  SetTimeTickChannel(channelID string) error
+  SetStatsChannel(channelID string) error
+  
+  BuildIndex(req BuildIndexRequest) (BuildIndexResponse, error)
+}
+```
+

docs/developer_guides/chap05_proxy.md

@@ -12,23 +12,57 @@
 
 ```go
 type Client interface {
+  RegisterLink() (ProxyInfo, error)
+  RegisterNode(req NodeInfo) (InitParams, error)
   GetTimeTickChannel() (string, error)
   GetStatsChannel() (string, error)
 }
 ```
 
-
-
-#### 6.1 Gateway API
+* *RegisterLink*
 
 ```go
 type ProxyInfo struct {
   Address string
   Port int32
 }
+```
 
-type Client interface {
-  RegisterLink() (ProxyInfo, error)
+* *RegisterNode*
+
+```go
+type NodeInfo struct {}
+
+type InitParams struct {}
+```
+
+
+
+#### 6.0 ProxyNode
+
+```go
+type ProxyNode interface {
+  Start() error
+  Close() error
+  
+  SetTimeTickChannel(channelID string) error
+  SetStatsChannel(channelID string) error
+  
+	CreateCollection(req CreateCollectionRequest) error
+  DropCollection(req DropCollectionRequest) error
+  HasCollection(req HasCollectionRequest) (bool, error)
+  DescribeCollection(req DescribeCollectionRequest) (CollectionDescription, error)
+  ShowCollections(req ShowCollectionRequest) ([]string, error)
+  CreatePartition(req CreatePartitionRequest) error
+  DropPartition(req DropPartitionRequest) error
+  HasPartition(req HasPartitionRequest) (bool, error)
+  DescribePartition(req DescribePartitionRequest) (PartitionDescription, error)
+  ShowPartitions(req ShowPartitionRequest) ([]string, error)
+  CreateIndex(req CreateIndexRequest) error
+  DescribeIndex(DescribeIndexRequest) (DescribeIndexResponse, error)
+  
+  Insert(req RowBatch) (InsertResponse, error)
+  Search(req SearchRequest) (SearchResults, error)
 }
 ```
 

docs/developer_guides/chap07_query_service.md

@@ -2,8 +2,6 @@
 
 ## 8. Query Service
 
-
-
 #### 8.1 Overview
 
 <img src="./figs/query_service.jpeg" width=700>
@@ -14,6 +12,7 @@
 
 ```go
 type Client interface {
+  RegisterNode(req NodeInfo) (InitParams, error)
   DescribeService() (ServiceDescription, error)
   DescribeParition(req DescribeParitionRequest) (PartitionDescriptions, error)
   LoadPartitions(req LoadPartitonRequest) error
@@ -26,10 +25,27 @@ type Client interface {
 
 
 
+* *RegisterNode*
+
+```go
+type NodeInfo struct {}
+
+type InitParams struct {}
+```
+
 * *DescribeService*
 
 ```go
+type NodeState = int
+
+const (
+  INITIALIZING NodeState = 0
+  HEALTHY NodeState = 1
+  ABNORMAL NodeState = 2
+)
+
 type QueryNodeDescription struct {
+  NodeState NodeState
   ResourceCost ResourceCost 
 }
 
@@ -62,11 +78,12 @@ type PartitionState = int
 
 const (
   NOT_EXIST PartitionState = 0
-  ON_DISK PartitionState = 1
-  PARTIAL_IN_MEMORY PartitionState = 2
-	IN_MEMORY PartitionState = 3
-  PARTIAL_IN_GPU PartitionState = 4
-  IN_GPU PartitionState = 5
+  NOT_PRESENT PartitionState = 1
+  ON_DISK PartitionState = 2
+  PARTIAL_IN_MEMORY PartitionState = 3
+	IN_MEMORY PartitionState = 4
+  PARTIAL_IN_GPU PartitionState = 5
+  IN_GPU PartitionState = 6
 )
 
 type ResourceCost struct {
@@ -122,6 +139,33 @@ type ReleasePartitionRequest struct {
 
 
 
+* *LoadSegments*
+
+```go
+type LoadSegmentRequest struct {
+  DbID UniqueID
+  CollectionID UniqueID
+  PartitionID UniqueID
+  SegmentIDs []UniqueID
+  FieldIDs []int64
+}
+```
+
+
+
+* *ReleaseSegments*
+
+```go
+type ReleaseSegmentRequest struct {
+  DbID UniqueID
+  CollectionID UniqueID
+  PartitionID UniqueID
+  SegmentIDs []UniqueID
+}
+```
+
+
+
 #### 8.2 Query Node
 
 ```go
@@ -129,23 +173,20 @@ type QueryNode interface {
   Start() error
   Close() error
   
-  AddQueryStream(requestStream MsgStream, resultStream MsgStream) error
-  RemoveQueryStream(requestStreamID string) error
-  WatchDmStreams(insertStreams MsgStream) error
-  WatchDdStream(stream MsgStream) error
-  SetTimeTickStream(stream MsgStream) error
-  SetStatsStream(stream MsgStream) error
+  AddQueryChannel(channelIDs QueryChannels) error
+  RemoveQueryChannel(channelIDs QueryChannels) error
+  WatchDmChannels(insertChannelIDs []string) error
+  //SetTimeTickChannel(channelID string) error
+  //SetStatsChannel(channelID string) error
   
-  LoadSegments(DbID UniqueID, CollID UniqueID, PartitionID UniqueID, SegIDs []UniqueID, FieldIDs []int64) error
-  ReleaseSegments(DbID UniqueID, CollID UniqueID, PartitionID UniqueID, SegIDs []UniqueID) error
-  DescribeParition(DbID UniqueID, CollID UniqueID, PartitionID UniqueID) (PartitionDescription, error)
+  LoadSegments(req LoadSegmentRequest) error
+  ReleaseSegments(req ReleaseSegmentRequest) error
+  DescribeParition(req DescribeParitionRequest) (PartitionDescriptions, error)
 }
 ```
 
 
 
-
-
 #### 8.2 Collection Replica
 
 $collectionReplica$ contains a in-memory local copy of persistent collections. In common cases, the system has multiple query nodes. Data of a collection will be distributed across all the available query nodes, and each query node's $collectionReplica$ will maintain its own share (only part of the collection).

docs/developer_guides/chap09_data_service.md

@@ -8,13 +8,13 @@
 
 <img src="./figs/data_service.jpeg" width=700>
 
-
-#### 8.2 API
+#### 8.2 Data Service API
 
 ```go
 type Client interface {
+  RegisterNode(req NodeInfo) (InitParams, error)
   AssignSegmentID(req AssignSegIDRequest) (AssignSegIDResponse, error)
-  Flush(req FlushRequest) (error)
+  Flush(req FlushRequest) error
   GetInsertBinlogPaths(req InsertBinlogPathRequest) (InsertBinlogPathsResponse, error)
   GetInsertChannels(req InsertChannelRequest) ([]string, error)
   GetTimeTickChannel() (string, error)
@@ -24,6 +24,14 @@ type Client interface {
 
 
 
+* *RegisterNode*
+
+```go
+type NodeInfo struct {}
+
+type InitParams struct {}
+```
+
 * *AssignSegmentID*
 
 ```go
@@ -88,3 +96,21 @@ type InsertChannelRequest struct {
 }
 ```
 
+
+
+#### 8.2 Data Node API
+
+```go
+type DataNode interface {
+  Start() error
+  Close() error
+  
+  WatchDmChannels(channelIDs []string) error
+  WatchDdChannel(channelID string) error
+  SetTimeTickChannel(channelID string) error
+  SetStatsChannel(channelID string) error
+  
+  Flush(req FlushRequest) error
+}
+```
+

docs/jaeger_guides/Opentracing User Guide.md

+# Opentracing User Guide
+
+This guide mainly describes the use of jaeger and the commonly used display meanings.
+
+Jaeger, inspired by [Dapper](https://research.google.com/pubs/pub36356.html) and [OpenZipkin](https://zipkin.io/), is a distributed tracing platform created by [Uber Technologies](https://uber.github.io/) and donated to [Cloud Native Computing Foundation](https://cncf.io/). It can be used for monitoring microservices-based distributed systems:
+
+- Distributed context propagation
+- Distributed transaction monitoring
+- Root cause analysis
+- Service dependency analysis
+- Performance / latency optimization
+
+See also:
+
+- Jaeger [documentation](https://jaegertracing.io/docs/) for getting started, operational details, and other information.
+- Blog post [Evolving Distributed Tracing at Uber](https://eng.uber.com/distributed-tracing/).
+- Tutorial / walkthrough [Take OpenTracing for a HotROD ride](https://medium.com/@YuriShkuro/take-opentracing-for-a-hotrod-ride-f6e3141f7941).
+
+
+
+We mainly use jaeger as a implementation of opentracing.
+
+Two request: **Insert Request** and **Search Request** in milvus-distributed system is traced at this stage.
+
+
+
+## Jaeger Home page
+
+![](./figs/jaeger_home_page.png)
+
+
+
+### Lookup by Trace ID
+
+The use of the search box requires configuration of the log collection system. For example, if the log collection system collects the log, if it is an error log, find the Trace ID. Search in jaeger to quickly locate the error. So as to quickly solve the problem
+
+### Search
+
+### Service
+
+Filter with service name
+
+### Operation
+
+Operation in Service, eg request name, function name
+
+### Tags
+
+Set tag to facilitate search. Tag is defined in code
+
+### Lookback
+
+Filter with time.
+
+### Min Duraton Max Duration
+
+The minimum and maximum request duration, you can use this condition to find the time-consuming and short-term requests
+
+### Limit Result
+
+The max number of result
+
+## Search result
+
+You can search through the above conditions, and those that meet the conditions will appear in the right half.
+
+![](./figs/jaeger_single_search_result.png)
+
+The detailed information of search result.
+
+1. The upper left corner identifies the service name: tracing, Root span name: Insert grpc received and The first half of the Trace ID 46874e2.
+2. The duration of the entire request is shown in the upper right corner.
+3. 10675 Span means that there are 10675 operations, see the number of operations for each service in the middle. And the trace time is shown in the right.
+4. The user can select multiple trace with the box in the upper left, and then compare with them to find something different. For example, different insert request may take a different time. At this time, you can select two for comparison, and the comparison can be very easy to know which trace went wrong
+
+
+
+## Detailed trace information
+
+Click the search result. You can analyze the detail trace information.
+
+![](./figs/jaeger_detailed_trace_info.png)
+
+1. Duration: Total time consume.
+2. Service: The number of service called.
+3. Depth: Call chain depth.
+4. Total Spans: This call consists of 10 spans
+5. To enter the details, look at the left half first, showing the call chain of the entire request. The black represents the service name, and the gray kid represents the span name defined in the code.
+6. The duration of the right half of the code call. The length represents the time consumed by the Span in the entire call chain.
+
+
+
+### Span Detail information
+
+Click the Span to see the detailed span information such as the last span in the picture above.
+
+1. Tags contains a series of custom tags. You can mark in the code what type of call this Span is, request method, call result, call, etc. All the information it contains can be filtered by the Tags on the homepage.
+2. Process can locate which specific server processing this data.
+3. Logs are the logs printed by this span during the call.
+
+
+
+
+
+## More
+
+More usage guides will be updated in the future
+

go.mod

@@ -4,14 +4,17 @@ go 1.15
 
 require (
 	code.cloudfoundry.org/bytefmt v0.0.0-20200131002437-cf55d5288a48 // indirect
+	github.com/HdrHistogram/hdrhistogram-go v1.0.1 // indirect
 	github.com/apache/pulsar-client-go v0.1.1
-	github.com/aws/aws-sdk-go v1.30.8
+	github.com/apache/thrift v0.13.0
+	github.com/aws/aws-sdk-go v1.30.8 // indirect
 	github.com/coreos/etcd v3.3.25+incompatible // indirect
-	github.com/cznic/mathutil v0.0.0-20181122101859-297441e03548
+	github.com/cznic/mathutil v0.0.0-20181122101859-297441e03548 // indirect
 	github.com/frankban/quicktest v1.10.2 // indirect
 	github.com/fsnotify/fsnotify v1.4.9 // indirect
 	github.com/git-hooks/git-hooks v1.3.1 // indirect
 	github.com/golang/groupcache v0.0.0-20200121045136-8c9f03a8e57e // indirect
+	github.com/golang/mock v1.3.1
 	github.com/golang/protobuf v1.3.2
 	github.com/google/btree v1.0.0
 	github.com/klauspost/compress v1.10.11 // indirect
@@ -20,12 +23,12 @@ require (
 	github.com/niemeyer/pretty v0.0.0-20200227124842-a10e7caefd8e // indirect
 	github.com/onsi/ginkgo v1.12.1 // indirect
 	github.com/onsi/gomega v1.10.0 // indirect
-	github.com/opentracing/opentracing-go v1.2.0 // indirect
+	github.com/opentracing/opentracing-go v1.2.0
 	github.com/pierrec/lz4 v2.5.2+incompatible // indirect
 	github.com/pingcap/check v0.0.0-20200212061837-5e12011dc712 // indirect
 	github.com/pingcap/errors v0.11.4 // indirect
 	github.com/pingcap/log v0.0.0-20200828042413-fce0951f1463 // indirect
-	github.com/pivotal-golang/bytefmt v0.0.0-20200131002437-cf55d5288a48
+	github.com/pivotal-golang/bytefmt v0.0.0-20200131002437-cf55d5288a48 // indirect
 	github.com/prometheus/client_golang v1.5.1 // indirect
 	github.com/prometheus/common v0.10.0 // indirect
 	github.com/prometheus/procfs v0.1.3 // indirect
@@ -35,7 +38,9 @@ require (
 	github.com/spf13/cast v1.3.0
 	github.com/spf13/viper v1.7.1
 	github.com/stretchr/testify v1.6.1
-	github.com/tikv/client-go v0.0.0-20200824032810-95774393107b
+	github.com/tikv/client-go v0.0.0-20200824032810-95774393107b // indirect
+	github.com/uber/jaeger-client-go v2.25.0+incompatible
+	github.com/uber/jaeger-lib v2.4.0+incompatible // indirect
 	github.com/urfave/cli v1.22.5 // indirect
 	github.com/yahoo/athenz v1.9.16 // indirect
 	go.etcd.io/etcd v0.5.0-alpha.5.0.20191023171146-3cf2f69b5738
@@ -50,7 +55,7 @@ require (
 	google.golang.org/genproto v0.0.0-20200122232147-0452cf42e150 // indirect
 	google.golang.org/grpc v1.31.0
 	gopkg.in/check.v1 v1.0.0-20200227125254-8fa46927fb4f // indirect
-	gopkg.in/yaml.v2 v2.3.0
+	gopkg.in/yaml.v2 v2.3.0 // indirect
 	honnef.co/go/tools v0.0.1-2020.1.4 // indirect
 	sigs.k8s.io/yaml v1.2.0 // indirect
 )

go.sum

@@ -15,6 +15,8 @@ dmitri.shuralyov.com/gpu/mtl v0.0.0-20190408044501-666a987793e9/go.mod h1:H6x//7
 github.com/BurntSushi/toml v0.3.1 h1:WXkYYl6Yr3qBf1K79EBnL4mak0OimBfB0XUf9Vl28OQ=
 github.com/BurntSushi/toml v0.3.1/go.mod h1:xHWCNGjB5oqiDr8zfno3MHue2Ht5sIBksp03qcyfWMU=
 github.com/BurntSushi/xgb v0.0.0-20160522181843-27f122750802/go.mod h1:IVnqGOEym/WlBOVXweHU+Q+/VP0lqqI8lqeDx9IjBqo=
+github.com/HdrHistogram/hdrhistogram-go v1.0.1 h1:GX8GAYDuhlFQnI2fRDHQhTlkHMz8bEn0jTI6LJU0mpw=
+github.com/HdrHistogram/hdrhistogram-go v1.0.1/go.mod h1:BWJ+nMSHY3L41Zj7CA3uXnloDp7xxV0YvstAE7nKTaM=
 github.com/OneOfOne/xxhash v1.2.2/go.mod h1:HSdplMjZKSmBqAxg5vPj2TmRDmfkzw+cTzAElWljhcU=
 github.com/alecthomas/template v0.0.0-20160405071501-a0175ee3bccc/go.mod h1:LOuyumcjzFXgccqObfd/Ljyb9UuFJ6TxHnclSeseNhc=
 github.com/alecthomas/template v0.0.0-20190718012654-fb15b899a751 h1:JYp7IbQjafoB+tBA3gMyHYHrpOtNuDiK/uB5uXxq5wM=
@@ -24,6 +26,8 @@ github.com/alecthomas/units v0.0.0-20190717042225-c3de453c63f4 h1:Hs82Z41s6SdL1C
 github.com/alecthomas/units v0.0.0-20190717042225-c3de453c63f4/go.mod h1:ybxpYRFXyAe+OPACYpWeL0wqObRcbAqCMya13uyzqw0=
 github.com/apache/pulsar-client-go v0.1.1 h1:v/kU+2ZCC6yFIcbZrFtWa9/nvVzVr18L+xYJUvZSxEQ=
 github.com/apache/pulsar-client-go v0.1.1/go.mod h1:mlxC65KL1BLhGO2bnT9zWMttVzR2czVPb27D477YpyU=
+github.com/apache/thrift v0.13.0 h1:5hryIiq9gtn+MiLVn0wP37kb/uTeRZgN08WoCsAhIhI=
+github.com/apache/thrift v0.13.0/go.mod h1:cp2SuWMxlEZw2r+iP2GNCdIi4C1qmUzdZFSVb+bacwQ=
 github.com/ardielle/ardielle-go v1.5.2 h1:TilHTpHIQJ27R1Tl/iITBzMwiUGSlVfiVhwDNGM3Zj4=
 github.com/ardielle/ardielle-go v1.5.2/go.mod h1:I4hy1n795cUhaVt/ojz83SNVCYIGsAFAONtv2Dr7HUI=
 github.com/ardielle/ardielle-tools v1.5.4/go.mod h1:oZN+JRMnqGiIhrzkRN9l26Cej9dEx4jeNG6A+AdkShk=
@@ -117,6 +121,7 @@ github.com/golang/groupcache v0.0.0-20200121045136-8c9f03a8e57e h1:1r7pUrabqp18h
 github.com/golang/groupcache v0.0.0-20200121045136-8c9f03a8e57e/go.mod h1:cIg4eruTrX1D+g88fzRXU5OdNfaM+9IcxsU14FzY7Hc=
 github.com/golang/mock v1.1.1/go.mod h1:oTYuIxOrZwtPieC+H1uAHpcLFnEyAGVDL/k47Jfbm0A=
 github.com/golang/mock v1.2.0/go.mod h1:oTYuIxOrZwtPieC+H1uAHpcLFnEyAGVDL/k47Jfbm0A=
+github.com/golang/mock v1.3.1 h1:qGJ6qTW+x6xX/my+8YUVl4WNpX9B7+/l2tRsHGZ7f2s=
 github.com/golang/mock v1.3.1/go.mod h1:sBzyDLLjw3U8JLTeZvSv8jJB+tU5PVekmnlKIyFUx0Y=
 github.com/golang/protobuf v0.0.0-20180814211427-aa810b61a9c7/go.mod h1:6lQm79b+lXiMfvg/cZm0SGofjICqVBUtrP5yJMmIC1U=
 github.com/golang/protobuf v1.2.0/go.mod h1:6lQm79b+lXiMfvg/cZm0SGofjICqVBUtrP5yJMmIC1U=
@@ -168,6 +173,7 @@ github.com/grpc-ecosystem/grpc-gateway v1.8.1/go.mod h1:vNeuVxBJEsws4ogUvrchl83t
 github.com/grpc-ecosystem/grpc-gateway v1.9.0/go.mod h1:vNeuVxBJEsws4ogUvrchl83t/GYV9WGTSLVdBhOQFDY=
 github.com/grpc-ecosystem/grpc-gateway v1.9.5 h1:UImYN5qQ8tuGpGE16ZmjvcTtTw24zw1QAp/SlnNrZhI=
 github.com/grpc-ecosystem/grpc-gateway v1.9.5/go.mod h1:vNeuVxBJEsws4ogUvrchl83t/GYV9WGTSLVdBhOQFDY=
+github.com/grpc-ecosystem/grpc-opentracing v0.0.0-20180507213350-8e809c8a8645/go.mod h1:6iZfnjpejD4L/4DwD7NryNaJyCQdzwWwH2MWhCA90Kw=
 github.com/hashicorp/consul/api v1.1.0/go.mod h1:VmuI/Lkw1nC05EYQWNKwWGbkg+FbDBtguAZLlVdkD9Q=
 github.com/hashicorp/consul/sdk v0.1.1/go.mod h1:VKf9jXwCTEY1QZP2MOLRhb5i/I/ssyNV1vwHyQBF0x8=
 github.com/hashicorp/errwrap v1.0.0/go.mod h1:YH+1FKiLXxHSkmPseP+kNlulaMuP3n2brvKWEqk/Jc4=
@@ -343,6 +349,7 @@ github.com/prometheus/procfs v0.0.8/go.mod h1:7Qr8sr6344vo1JqZ6HhLceV9o3AJ1Ff+Gx
 github.com/prometheus/procfs v0.1.3 h1:F0+tqvhOksq22sc6iCHF5WGlWjdwj92p0udFh1VFBS8=
 github.com/prometheus/procfs v0.1.3/go.mod h1:lV6e/gmhEcM9IjHGsFOCxxuZ+z1YqCvr4OA4YeYWdaU=
 github.com/prometheus/tsdb v0.7.1/go.mod h1:qhTCs0VvXwvX/y3TZrWD7rabWM+ijKTux40TwIPHuXU=
+github.com/protocolbuffers/protobuf v3.14.0+incompatible h1:8r0H76h/Q/lEnFFY60AuM23NOnaDMi6bd7zuboSYM+o=
 github.com/remyoudompheng/bigfft v0.0.0-20170806203942-52369c62f446 h1:/NRJ5vAYoqz+7sG51ubIDHXeWO8DlTSrToPu6q11ziA=
 github.com/remyoudompheng/bigfft v0.0.0-20170806203942-52369c62f446/go.mod h1:uYEyJGbgTkfkS4+E/PavXkNJcbFIpEtjt2B0KDQ5+9M=
 github.com/rogpeppe/fastuuid v0.0.0-20150106093220-6724a57986af/go.mod h1:XWv6SoW27p1b0cqNHllgS5HIMJraePCO15w5zCzIWYg=
@@ -403,6 +410,12 @@ github.com/tikv/client-go v0.0.0-20200824032810-95774393107b/go.mod h1:K0NcdVNrX
 github.com/tmc/grpc-websocket-proxy v0.0.0-20170815181823-89b8d40f7ca8/go.mod h1:ncp9v5uamzpCO7NfCPTXjqaC+bZgJeR0sMTm6dMHP7U=
 github.com/tmc/grpc-websocket-proxy v0.0.0-20190109142713-0ad062ec5ee5 h1:LnC5Kc/wtumK+WB441p7ynQJzVuNRJiqddSIE3IlSEQ=
 github.com/tmc/grpc-websocket-proxy v0.0.0-20190109142713-0ad062ec5ee5/go.mod h1:ncp9v5uamzpCO7NfCPTXjqaC+bZgJeR0sMTm6dMHP7U=
+github.com/uber/jaeger-client-go v1.6.0 h1:3+zLlq+4npI5fg8IsgAje3YsP7TcEdNzJScyqFIzxEQ=
+github.com/uber/jaeger-client-go v2.25.0+incompatible h1:IxcNZ7WRY1Y3G4poYlx24szfsn/3LvK9QHCq9oQw8+U=
+github.com/uber/jaeger-client-go v2.25.0+incompatible/go.mod h1:WVhlPFC8FDjOFMMWRy2pZqQJSXxYSwNYOkTr/Z6d3Kk=
+github.com/uber/jaeger-lib v1.5.0 h1:OHbgr8l656Ub3Fw5k9SWnBfIEwvoHQ+W2y+Aa9D1Uyo=
+github.com/uber/jaeger-lib v2.4.0+incompatible h1:fY7QsGQWiCt8pajv4r7JEvmATdCVaWxXbjwyYwsNaLQ=
+github.com/uber/jaeger-lib v2.4.0+incompatible/go.mod h1:ComeNDZlWwrWnDv8aPp0Ba6+uUTzImX/AauajbLI56U=
 github.com/ugorji/go v1.1.2/go.mod h1:hnLbHMwcvSihnDhEfx2/BzKp2xb0Y+ErdfYcrs9tkJQ=
 github.com/ugorji/go/codec v0.0.0-20190204201341-e444a5086c43/go.mod h1:iT03XoTwV7xq/+UGwKO3UbC1nNNlopQiY61beSdrtOA=
 github.com/unrolled/render v1.0.0 h1:XYtvhA3UkpB7PqkvhUFYmpKD55OudoIeygcfus4vcd4=

internal/core/src/indexbuilder/IndexWrapper.cpp

@@ -34,9 +34,6 @@ IndexWrapper::IndexWrapper(const char* serialized_type_params, const char* seria
     auto mode = get_config_by_name<std::string>("index_mode");
     auto index_mode = mode.has_value() ? mode_map[mode.value()] : knowhere::IndexMode::MODE_CPU;
 
-    auto index_type = get_index_type();
-    auto metric_type = get_metric_type();
-    AssertInfo(!is_unsupported(index_type, metric_type), index_type + " doesn't support metric: " + metric_type);
     index_ = knowhere::VecIndexFactory::GetInstance().CreateVecIndex(get_index_type(), index_mode);
     Assert(index_ != nullptr);
 }
@@ -266,21 +263,6 @@ IndexWrapper::get_index_type() {
     return type.has_value() ? type.value() : knowhere::IndexEnum::INDEX_FAISS_IVFPQ;
 }
 
-std::string
-IndexWrapper::get_metric_type() {
-    auto type = get_config_by_name<std::string>(knowhere::Metric::TYPE);
-    if (type.has_value()) {
-        return type.value();
-    } else {
-        auto index_type = get_index_type();
-        if (is_in_bin_list(index_type)) {
-            return knowhere::Metric::JACCARD;
-        } else {
-            return knowhere::Metric::L2;
-        }
-    }
-}
-
 std::unique_ptr<IndexWrapper::QueryResult>
 IndexWrapper::Query(const knowhere::DatasetPtr& dataset) {
     return std::move(QueryImpl(dataset, config_));

internal/core/src/indexbuilder/IndexWrapper.h

@@ -59,9 +59,6 @@ class IndexWrapper {
     std::string
     get_index_type();
 
-    std::string
-    get_metric_type();
-
     template <typename T>
     std::optional<T>
     get_config_by_name(std::string name);