Skip to content
Snippets Groups Projects
Unverified Commit 70e92669 authored by Yee's avatar Yee Committed by GitHub
Browse files

Improve project explained columns format and Fix compile errors (#583)

* Fix project explain string format

* Fix compile error

* Restore include headers

* Address comment
parent cee050b8
No related branches found
No related tags found
No related merge requests found
......@@ -27,6 +27,7 @@ SET(CONTEXT_TEST_LIBS
$<TARGET_OBJECTS:common_time_utils_obj>
$<TARGET_OBJECTS:common_graph_obj>
$<TARGET_OBJECTS:common_ft_es_graph_adapter_obj>
$<TARGET_OBJECTS:common_ws_common_obj>
$<TARGET_OBJECTS:util_obj>
$<TARGET_OBJECTS:context_obj>
$<TARGET_OBJECTS:expr_visitor_obj>
......
......@@ -31,6 +31,7 @@ SET(EXEC_QUERY_TEST_OBJS
$<TARGET_OBJECTS:common_http_client_obj>
$<TARGET_OBJECTS:common_time_utils_obj>
$<TARGET_OBJECTS:common_ft_es_graph_adapter_obj>
$<TARGET_OBJECTS:common_ws_common_obj>
$<TARGET_OBJECTS:session_obj>
$<TARGET_OBJECTS:graph_flags_obj>
$<TARGET_OBJECTS:parser_obj>
......
......@@ -29,6 +29,7 @@ set(OPTIMIZER_TEST_LIB
$<TARGET_OBJECTS:common_time_utils_obj>
$<TARGET_OBJECTS:common_graph_obj>
$<TARGET_OBJECTS:common_ft_es_graph_adapter_obj>
$<TARGET_OBJECTS:common_ws_common_obj>
$<TARGET_OBJECTS:idgenerator_obj>
$<TARGET_OBJECTS:expr_visitor_obj>
$<TARGET_OBJECTS:session_obj>
......
......@@ -29,6 +29,7 @@ set(PARSER_TEST_LIBS
$<TARGET_OBJECTS:common_process_obj>
$<TARGET_OBJECTS:common_time_utils_obj>
$<TARGET_OBJECTS:common_ft_es_graph_adapter_obj>
$<TARGET_OBJECTS:common_ws_common_obj>
$<TARGET_OBJECTS:session_obj>
$<TARGET_OBJECTS:graph_flags_obj>
$<TARGET_OBJECTS:graph_auth_obj>
......
......@@ -7,6 +7,7 @@
#include "planner/Query.h"
#include <folly/String.h>
#include <folly/dynamic.h>
#include <folly/json.h>
#include "util/ToJson.h"
......@@ -153,7 +154,14 @@ void Project::clone(const Project &p) {
std::unique_ptr<PlanNodeDescription> Project::explain() const {
auto desc = SingleInputNode::explain();
addDescription("columns", cols_ ? cols_->toString() : "", desc.get());
auto columns = folly::dynamic::array();
if (cols_) {
for (const auto* col : cols_->columns()) {
DCHECK(col != nullptr);
columns.push_back(col->toString());
}
}
addDescription("columns", folly::toJson(columns), desc.get());
return desc;
}
......
......@@ -29,6 +29,7 @@ nebula_add_test(
$<TARGET_OBJECTS:common_time_utils_obj>
$<TARGET_OBJECTS:common_graph_obj>
$<TARGET_OBJECTS:common_ft_es_graph_adapter_obj>
$<TARGET_OBJECTS:common_ws_common_obj>
$<TARGET_OBJECTS:idgenerator_obj>
$<TARGET_OBJECTS:expr_visitor_obj>
$<TARGET_OBJECTS:session_obj>
......
......@@ -48,6 +48,7 @@ set(VALIDATOR_TEST_LIBS
$<TARGET_OBJECTS:common_time_utils_obj>
$<TARGET_OBJECTS:common_graph_obj>
$<TARGET_OBJECTS:common_ft_es_graph_adapter_obj>
$<TARGET_OBJECTS:common_ws_common_obj>
)
nebula_add_test(
......
......@@ -49,6 +49,7 @@ nebula_add_test(
$<TARGET_OBJECTS:common_time_utils_obj>
$<TARGET_OBJECTS:common_graph_obj>
$<TARGET_OBJECTS:common_ft_es_graph_adapter_obj>
$<TARGET_OBJECTS:common_ws_common_obj>
LIBRARIES
gtest
${THRIFT_LIBRARIES}
......
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment