Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
2
221cb0332
Manage
Activity
Members
Labels
Plan
Issues
0
Issue boards
Milestones
Wiki
Code
Merge requests
0
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Build
Pipelines
Jobs
Pipeline schedules
Artifacts
Deploy
Releases
Package Registry
Operate
Environments
Terraform modules
Monitor
Incidents
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
Summer2022
221cb0332
Commits
51ac0465
Commit
51ac0465
authored
2 years ago
by
zhaoting
Browse files
Options
Downloads
Patches
Plain Diff
supplement PR submission process
parent
dcb1ff3e
No related branches found
Branches containing commit
No related tags found
No related merge requests found
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
CONTRIBUTING.md
+1
-0
1 addition, 0 deletions
CONTRIBUTING.md
CONTRIBUTING_CN.md
+1
-0
1 addition, 0 deletions
CONTRIBUTING_CN.md
with
2 additions
and
0 deletions
CONTRIBUTING.md
+
1
−
0
View file @
51ac0465
...
...
@@ -124,6 +124,7 @@ When reporting issues, refer to this format:
-
Raise your idea as an
*issue*
on
[
GitHub
](
https://github.com/mindspore-ai/mindspore/issues
)
or
[
Gitee
](
https://gitee.com/mindspore/mindspore/issues
)
-
If it is a new feature that needs lots of design details, a design proposal should also be submitted.
-
After reaching consensus in the issue discussions and design proposal reviews, complete the development on the forked repo and submit a PR.
-
After submitting the PR, you need to sign the CLA, check the code according to the checklist, and comment
*/retest*
to run the code check.
-
None of PRs is permitted until it receives
**2+ LGTM**
from approvers. Please NOTICE that approver is NOT allowed to add
*LGTM*
on his own PR.
-
After PR is sufficiently discussed, it will get merged, abandoned or rejected depending on the outcome of the discussion.
...
...
This diff is collapsed.
Click to expand it.
CONTRIBUTING_CN.md
+
1
−
0
View file @
51ac0465
...
...
@@ -123,6 +123,7 @@
-
在
[
GitHub
](
https://github.com/mindspore-ai/mindspore/issues
)
或者
[
Gitee
](
https://gitee.com/mindspore/mindspore/issues
)
针对一个
*issue*
提出你的解决方案。
-
在议题讨论和设计方案审核达成共识后,fork后完成开发后提交PR
-
提交PR后需要:签订cla,根据自检列表完成代码自检,在评论区评论/retest运行代码检查
-
贡献者的代码需要至少两个committer
*LGTM*
,PR才可以被允许推送,注意贡献者不允许在自己的PR上添加
*LGTM*
。
-
在PR被详细评审后,这个PR将会被确定能否被合入。
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment