Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
2
229660230
Manage
Activity
Members
Labels
Plan
Issues
0
Issue boards
Milestones
Wiki
Code
Merge requests
0
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Build
Pipelines
Jobs
Pipeline schedules
Artifacts
Deploy
Releases
Package Registry
Operate
Environments
Terraform modules
Monitor
Incidents
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
Summer2022
229660230
Commits
19227df5
Commit
19227df5
authored
2 years ago
by
ioito
Browse files
Options
Downloads
Patches
Plain Diff
fix(region): disk save task
parent
5796950b
No related branches found
No related tags found
No related merge requests found
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
pkg/compute/tasks/disk_save_task.go
+49
-40
49 additions, 40 deletions
pkg/compute/tasks/disk_save_task.go
with
49 additions
and
40 deletions
pkg/compute/tasks/disk_save_task.go
+
49
−
40
View file @
19227df5
...
...
@@ -16,9 +16,10 @@ package tasks
import
(
"context"
"fmt"
"yunion.io/x/jsonutils"
"yunion.io/x/
log
"
"yunion.io/x/
pkg/errors
"
api
"yunion.io/x/onecloud/pkg/apis/compute"
"yunion.io/x/onecloud/pkg/cloudcommon/db"
...
...
@@ -26,7 +27,7 @@ import (
"yunion.io/x/onecloud/pkg/compute/models"
"yunion.io/x/onecloud/pkg/compute/options"
"yunion.io/x/onecloud/pkg/mcclient/auth"
mc
"yunion.io/x/onecloud/pkg/mcclient/modules"
"yunion.io/x/onecloud/pkg/mcclient/modules"
)
type
DiskSaveTask
struct
{
...
...
@@ -51,31 +52,38 @@ func (self *DiskSaveTask) GetMasterHost(disk *models.SDisk) *models.SHost {
return
nil
}
func
(
self
*
DiskSaveTask
)
taskFailed
(
ctx
context
.
Context
,
disk
*
models
.
SDisk
,
err
error
)
{
disk
.
SetDiskReady
(
ctx
,
self
.
GetUserCred
(),
err
.
Error
())
db
.
OpsLog
.
LogEvent
(
disk
,
db
.
ACT_SAVE_FAIL
,
err
.
Error
(),
self
.
GetUserCred
())
if
imageId
,
_
:=
self
.
GetParams
()
.
GetString
(
"image_id"
);
len
(
imageId
)
>
0
{
s
:=
auth
.
GetAdminSession
(
ctx
,
options
.
Options
.
Region
,
""
)
modules
.
Images
.
PerformAction
(
s
,
imageId
,
"status"
,
jsonutils
.
Marshal
(
map
[
string
]
string
{
"status"
:
"killed"
,
"reason"
:
err
.
Error
()}))
}
self
.
SetStageFailed
(
ctx
,
jsonutils
.
NewString
(
err
.
Error
()))
}
func
(
self
*
DiskSaveTask
)
OnInit
(
ctx
context
.
Context
,
obj
db
.
IStandaloneModel
,
data
jsonutils
.
JSONObject
)
{
disk
:=
obj
.
(
*
models
.
SDisk
)
if
host
:=
self
.
GetMasterHost
(
disk
);
host
==
nil
{
reason
:=
"Cannot find host for disk"
disk
.
SetDiskReady
(
ctx
,
self
.
GetUserCred
(),
reason
)
self
.
TaskFailed
(
ctx
,
jsonutils
.
NewString
(
reason
))
db
.
OpsLog
.
LogEvent
(
disk
,
db
.
ACT_SAVE_FAIL
,
reason
,
self
.
GetUserCred
())
}
else
{
disk
.
SetStatus
(
self
.
GetUserCred
(),
api
.
DISK_START_SAVE
,
""
)
for
_
,
guest
:=
range
disk
.
GetGuests
()
{
guest
.
SetStatus
(
self
.
GetUserCred
(),
api
.
VM_SAVE_DISK
,
""
)
}
self
.
StartBackupDisk
(
ctx
,
disk
,
host
)
host
:=
self
.
GetMasterHost
(
disk
)
if
host
==
nil
{
self
.
taskFailed
(
ctx
,
disk
,
fmt
.
Errorf
(
"Cannot find host for disk"
))
return
}
disk
.
SetStatus
(
self
.
GetUserCred
(),
api
.
DISK_START_SAVE
,
""
)
for
_
,
guest
:=
range
disk
.
GetGuests
()
{
guest
.
SetStatus
(
self
.
GetUserCred
(),
api
.
VM_SAVE_DISK
,
""
)
}
self
.
StartBackupDisk
(
ctx
,
disk
,
host
)
}
func
(
self
*
DiskSaveTask
)
StartBackupDisk
(
ctx
context
.
Context
,
disk
*
models
.
SDisk
,
host
*
models
.
SHost
)
{
self
.
SetStage
(
"
on_d
isk
_b
ackup
_c
omplete"
,
nil
)
self
.
SetStage
(
"
OnD
isk
B
ackup
C
omplete"
,
nil
)
disk
.
SetStatus
(
self
.
GetUserCred
(),
api
.
DISK_SAVING
,
""
)
imageId
,
_
:=
self
.
GetParams
()
.
GetString
(
"image_id"
)
if
err
:=
host
.
GetHostDriver
()
.
RequestPrepareSaveDiskOnHost
(
ctx
,
host
,
disk
,
imageId
,
self
);
err
!=
nil
{
log
.
Errorf
(
"Backup failed: %v"
,
err
)
disk
.
SetDiskReady
(
ctx
,
self
.
GetUserCred
(),
err
.
Error
())
self
.
TaskFailed
(
ctx
,
jsonutils
.
NewString
(
err
.
Error
()))
db
.
OpsLog
.
LogEvent
(
disk
,
db
.
ACT_SAVE_FAIL
,
err
.
Error
(),
self
.
GetUserCred
())
err
:=
host
.
GetHostDriver
()
.
RequestPrepareSaveDiskOnHost
(
ctx
,
host
,
disk
,
imageId
,
self
)
if
err
!=
nil
{
self
.
taskFailed
(
ctx
,
disk
,
errors
.
Wrapf
(
err
,
"RequestPrepareSaveDiskOnHost"
))
return
}
}
...
...
@@ -88,21 +96,20 @@ func (self *DiskSaveTask) OnDiskBackupCompleteFailed(ctx context.Context, disk *
func
(
self
*
DiskSaveTask
)
OnDiskBackupComplete
(
ctx
context
.
Context
,
disk
*
models
.
SDisk
,
data
*
jsonutils
.
JSONDict
)
{
disk
.
SetDiskReady
(
ctx
,
self
.
GetUserCred
(),
""
)
db
.
OpsLog
.
LogEvent
(
disk
,
db
.
ACT_SAVE
,
disk
.
GetShortDesc
(
ctx
),
self
.
GetUserCred
())
self
.
SetStageComplete
(
ctx
,
nil
)
imageId
,
_
:=
self
.
GetParams
()
.
GetString
(
"image_id"
)
if
host
:=
self
.
GetMasterHost
(
disk
)
;
host
==
nil
{
log
.
Errorf
(
"Saved disk Host mast not be
nil
"
)
self
.
T
askFailed
(
ctx
,
jsonutils
.
NewString
(
"Saved disk Host mast not be nil"
))
}
else
{
if
self
.
Params
.
Contains
(
"format"
)
{
format
,
_
:=
self
.
Params
.
Get
(
"format"
)
data
.
Add
(
format
,
"format"
)
}
if
err
:=
self
.
UploadDisk
(
ctx
,
host
,
disk
,
imageId
,
data
);
err
!=
nil
{
log
.
Errorf
(
"UploadDisk failed: %v"
,
err
)
self
.
TaskFailed
(
ctx
,
jsonutils
.
NewString
(
err
.
Error
()))
}
self
.
RefreshImageCache
(
ctx
,
imageId
)
host
:=
self
.
GetMasterHost
(
disk
)
if
host
==
nil
{
self
.
t
askFailed
(
ctx
,
disk
,
fmt
.
Errorf
(
"Saved disk Host mast not be nil"
))
return
}
if
self
.
Params
.
Contains
(
"format"
)
{
format
,
_
:=
self
.
Params
.
Get
(
"format"
)
data
.
Add
(
format
,
"format"
)
}
err
:=
self
.
UploadDisk
(
ctx
,
host
,
disk
,
imageId
,
data
)
if
err
!=
nil
{
self
.
taskFailed
(
ctx
,
disk
,
errors
.
Wrapf
(
err
,
"UploadDisk"
))
return
}
}
...
...
@@ -111,14 +118,16 @@ func (self *DiskSaveTask) RefreshImageCache(ctx context.Context, imageId string)
}
func
(
self
*
DiskSaveTask
)
UploadDisk
(
ctx
context
.
Context
,
host
*
models
.
SHost
,
disk
*
models
.
SDisk
,
imageId
string
,
data
*
jsonutils
.
JSONDict
)
error
{
self
.
SetStage
(
"OnUploadDiskComplete"
,
nil
)
return
host
.
GetHostDriver
()
.
RequestSaveUploadImageOnHost
(
ctx
,
host
,
disk
,
imageId
,
self
,
jsonutils
.
Marshal
(
data
))
}
func
(
self
*
DiskSaveTask
)
TaskFailed
(
ctx
context
.
Context
,
reason
jsonutils
.
JSONObject
)
{
self
.
SetStageFailed
(
ctx
,
reason
)
if
imageId
,
err
:=
self
.
GetParams
()
.
GetString
(
"image_id"
);
err
!=
nil
&&
len
(
imageId
)
>
0
{
log
.
Errorf
(
"save disk task failed, set image %s killed"
,
imageId
)
s
:=
auth
.
GetAdminSession
(
ctx
,
options
.
Options
.
Region
,
""
)
mc
.
Images
.
Update
(
s
,
imageId
,
jsonutils
.
Marshal
(
map
[
string
]
string
{
"status"
:
"killed"
}))
}
func
(
self
*
DiskSaveTask
)
OnUploadDiskComplete
(
ctx
context
.
Context
,
disk
*
models
.
SDisk
,
data
jsonutils
.
JSONObject
)
{
imageId
,
_
:=
self
.
GetParams
()
.
GetString
(
"image_id"
)
self
.
RefreshImageCache
(
ctx
,
imageId
)
self
.
SetStageComplete
(
ctx
,
nil
)
}
func
(
self
*
DiskSaveTask
)
OnUploadDiskCompleteFailed
(
ctx
context
.
Context
,
disk
*
models
.
SDisk
,
data
jsonutils
.
JSONObject
)
{
self
.
taskFailed
(
ctx
,
disk
,
fmt
.
Errorf
(
data
.
String
()))
}
This diff is collapsed.
Click to expand it.
Preview
0%
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment