Skip to content
Snippets Groups Projects
Commit 2033aabd authored by vito.he's avatar vito.he
Browse files

Mod:for code review

parent e4bbb601
No related branches found
No related tags found
No related merge requests found
......@@ -91,8 +91,8 @@ type TypeDefinition struct {
}
// BuildServiceDefinition can build service definition which will be used to describe a service
func BuildServiceDefinition(service common.Service, url common.URL) ServiceDefinition {
sd := ServiceDefinition{}
func BuildServiceDefinition(service common.Service, url common.URL) *ServiceDefinition {
sd := &ServiceDefinition{}
sd.CanonicalName = url.Service()
for k, m := range service.Method() {
......
......@@ -106,7 +106,7 @@ func TestMetadataReport_StoreProviderMetadata(t *testing.T) {
mtr.StoreProviderMetadata(metadataId, getMockDefinition(metadataId, t))
}
func getMockDefinition(id *identifier.MetadataIdentifier, t *testing.T) definition.ServiceDefinition {
func getMockDefinition(id *identifier.MetadataIdentifier, t *testing.T) *definition.ServiceDefinition {
protocol := "dubbo"
beanName := "UserProvider"
url, err := common.NewURL(fmt.Sprintf(
......
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment