Skip to content
Snippets Groups Projects
Commit 2699fccd authored by 邹毅贤's avatar 邹毅贤
Browse files

fix review problems

parent ab046ef9
No related branches found
No related tags found
No related merge requests found
......@@ -115,7 +115,7 @@ func (r *etcdV3Registry) DoRegister(root string, node string) error {
}
func (r *etcdV3Registry) DoUnregister(root string, node string) error {
return r.client.Delete(path.Join(root, node))
return perrors.New("DoUnregister is not support in etcdV3Registry")
}
func (r *etcdV3Registry) CloseAndNilClient() {
......
......@@ -108,8 +108,7 @@ func (r *kubernetesRegistry) DoRegister(root string, node string) error {
}
func (r *kubernetesRegistry) DoUnregister(root string, node string) error {
panic("DoUnregister is not support in kubernetesRegistry")
return nil
return perrors.New("DoUnregister is not support in kubernetesRegistry")
}
func (r *kubernetesRegistry) DoSubscribe(svc *common.URL) (registry.Listener, error) {
......
......@@ -279,12 +279,9 @@ func (r *zkRegistry) getCloseListener(conf *common.URL) (*RegistryConfigurationL
zkListener, _ := configurationListener.(*RegistryConfigurationListener)
if zkListener != nil {
r.listenerLock.Lock()
if zkListener.isClosed {
r.listenerLock.Unlock()
return nil, perrors.New("configListener already been closed")
}
r.listenerLock.Unlock()
}
}
......@@ -299,6 +296,7 @@ func (r *zkRegistry) getCloseListener(conf *common.URL) (*RegistryConfigurationL
r.listenerLock.Lock()
listener := r.listener
r.listener = nil
r.listenerLock.Unlock()
r.dataListener.Close()
listener.Close()
......
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment