Skip to content
Snippets Groups Projects
Commit 38ca186a authored by Patrick's avatar Patrick
Browse files

optimize some code and fix imports

parent 0d237b1a
No related branches found
No related tags found
No related merge requests found
...@@ -38,10 +38,12 @@ type DirectEventDispatcher struct { ...@@ -38,10 +38,12 @@ type DirectEventDispatcher struct {
observer.BaseListenable observer.BaseListenable
} }
// NewDirectEventDispatcher ac constructor of DirectEventDispatcher
func NewDirectEventDispatcher() observer.EventDispatcher { func NewDirectEventDispatcher() observer.EventDispatcher {
return &DirectEventDispatcher{} return &DirectEventDispatcher{}
} }
// Dispatch event directly
func (ded *DirectEventDispatcher) Dispatch(event observer.Event) { func (ded *DirectEventDispatcher) Dispatch(event observer.Event) {
if event == nil { if event == nil {
logger.Warnf("[DirectEventDispatcher] dispatch event nil") logger.Warnf("[DirectEventDispatcher] dispatch event nil")
......
...@@ -19,11 +19,14 @@ package dispatcher ...@@ -19,11 +19,14 @@ package dispatcher
import ( import (
"fmt" "fmt"
"github.com/apache/dubbo-go/common/observer"
"reflect" "reflect"
"testing" "testing"
) )
import (
"github.com/apache/dubbo-go/common/observer"
)
func TestDirectEventDispatcher_Dispatch(t *testing.T) { func TestDirectEventDispatcher_Dispatch(t *testing.T) {
ded := NewDirectEventDispatcher() ded := NewDirectEventDispatcher()
ded.AddEventListener(&TestEventListener{}) ded.AddEventListener(&TestEventListener{})
......
...@@ -51,7 +51,7 @@ func SetAndInitGlobalDispatcher(name string) { ...@@ -51,7 +51,7 @@ func SetAndInitGlobalDispatcher(name string) {
if globalEventDispatcher != nil { if globalEventDispatcher != nil {
logger.Warnf("EventDispatcher already init. It will be replaced") logger.Warnf("EventDispatcher already init. It will be replaced")
} }
if dispatchers[name] == nil { if dp, ok := dispatchers[name]; !ok || dp == nil {
panic("EventDispatcher for " + name + " is not existing, make sure you have import the package.") panic("EventDispatcher for " + name + " is not existing, make sure you have import the package.")
} }
globalEventDispatcher = dispatchers[name]() globalEventDispatcher = dispatchers[name]()
......
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment