Skip to content
Snippets Groups Projects
Commit 43aa8179 authored by AlexStocks's avatar AlexStocks
Browse files

fix filter linter error

parent 66fe5ea1
No related branches found
No related tags found
No related merge requests found
......@@ -26,6 +26,10 @@ import (
"strings"
)
import (
"github.com/apache/dubbo-go/common/logger"
)
// Sign gets a signature string with given bytes
func Sign(metadata, key string) string {
return doSign([]byte(metadata), key)
......@@ -56,7 +60,9 @@ func toBytes(data []interface{}) ([]byte, error) {
func doSign(bytes []byte, key string) string {
mac := hmac.New(sha256.New, []byte(key))
mac.Write(bytes)
if _, err := mac.Write(bytes); err != nil {
logger.Error(err)
}
signature := mac.Sum(nil)
return base64.URLEncoding.EncodeToString(signature)
}
......
......@@ -144,7 +144,10 @@ func (suite *zookeeperMetadataReportTestSuite) testGetServiceDefinition() {
func test1(t *testing.T) {
testCluster, err := zk.StartTestCluster(1, nil, nil)
assert.NoError(t, err)
defer testCluster.Stop()
defer func() {
err := testCluster.Stop()
assert.Nil(t, err)
}()
url := newProviderRegistryUrl("127.0.0.1", testCluster.Servers[0].Port)
mf := extension.GetMetadataReportFactory("zookeeper")
......
......@@ -48,13 +48,20 @@ func TestMetadataServiceProxy_GetExportedURLs(t *testing.T) {
// when we implement them, adding UT
func TestNewMetadataService(t *testing.T) {
pxy := createPxy()
pxy.ServiceName()
pxy.PublishServiceDefinition(&common.URL{})
pxy.GetServiceDefinition(constant.ANY_VALUE, constant.ANY_VALUE, constant.ANY_VALUE)
pxy.Version()
pxy.GetSubscribedURLs()
pxy.UnsubscribeURL(&common.URL{})
pxy.GetServiceDefinitionByServiceKey("any")
_, err := pxy.ServiceName()
assert.Nil(t, err)
err = pxy.PublishServiceDefinition(&common.URL{})
assert.Nil(t, err)
_, err = pxy.GetServiceDefinition(constant.ANY_VALUE, constant.ANY_VALUE, constant.ANY_VALUE)
assert.Nil(t, err)
_, err = pxy.Version()
assert.Nil(t, err)
_, err = pxy.GetSubscribedURLs()
assert.Nil(t, err)
err = pxy.UnsubscribeURL(&common.URL{})
assert.Nil(t, err)
_, err = pxy.GetServiceDefinitionByServiceKey("any")
assert.Nil(t, err)
pxy.ExportURL(&common.URL{})
pxy.SubscribeURL(&common.URL{})
pxy.MethodMapper()
......
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment