Skip to content
Snippets Groups Projects
Unverified Commit 6a691cde authored by vito.he's avatar vito.he Committed by GitHub
Browse files

Merge pull request #251 from flycash/bug/registryProtocolSingleton

Fix: The registryProtocol should be singleton
parents 4955ab67 b77bb723
No related branches found
No related tags found
No related merge requests found
......@@ -338,10 +338,10 @@ func setProviderUrl(regURL *common.URL, providerURL *common.URL) {
}
func GetProtocol() protocol.Protocol {
if regProtocol != nil {
return regProtocol
if regProtocol == nil {
regProtocol = newRegistryProtocol()
}
return newRegistryProtocol()
return regProtocol
}
type wrappedInvoker struct {
......
......@@ -291,3 +291,8 @@ func TestExportWithApplicationConfig(t *testing.T) {
v2, _ := regProtocol.bounds.Load(getCacheKey(newUrl))
assert.NotNil(t, v2)
}
func TestGetProtocol(t *testing.T) {
singleton := GetProtocol()
assert.True(t, singleton == GetProtocol())
}
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment