Tested nacos discovery

registry/nacos/base_registry.go

@@ -22,12 +22,16 @@ import (
 	"strconv"
 	"strings"
 	"time"
+)
 
+import (
 	"github.com/nacos-group/nacos-sdk-go/clients"
 	"github.com/nacos-group/nacos-sdk-go/clients/naming_client"
 	nacosConstant "github.com/nacos-group/nacos-sdk-go/common/constant"
 	perrors "github.com/pkg/errors"
+)
 
+import (
 	"github.com/apache/dubbo-go/common"
 	"github.com/apache/dubbo-go/common/constant"
 )

registry/nacos/service_discovery.go

@@ -23,7 +23,9 @@ import (
 	"github.com/nacos-group/nacos-sdk-go/model"
 	"github.com/nacos-group/nacos-sdk-go/vo"
 	perrors "github.com/pkg/errors"
+)
 
+import (
 	"github.com/apache/dubbo-go/common"
 	"github.com/apache/dubbo-go/common/constant"
 	"github.com/apache/dubbo-go/common/extension"
@@ -105,7 +107,7 @@ func (n *nacosServiceDiscovery) GetServices() *gxset.HashSet {
 	}
 
 	for _, e := range services {
-		res.Add(e)
+		res.Add(e.Name)
 	}
 	return res
 }
@@ -249,7 +251,7 @@ func (n *nacosServiceDiscovery) toRegisterInstance(instance registry.ServiceInst
 		Enable:      instance.IsEnable(),
 		Healthy:     instance.IsHealthy(),
 		GroupName:   n.group,
-		Ephemeral: true,
+		Ephemeral:   true,
 	}
 }
 

registry/nacos/service_discovery_test.go

@@ -20,9 +20,13 @@ package nacos
 import (
 	"strconv"
 	"testing"
+)
 
+import (
 	"github.com/stretchr/testify/assert"
+)
 
+import (
 	"github.com/apache/dubbo-go/common"
 	"github.com/apache/dubbo-go/common/constant"
 	"github.com/apache/dubbo-go/common/extension"
@@ -65,20 +69,6 @@ func TestNacosServiceDiscovery_CRUD(t *testing.T) {
 		Port:        port,
 	})
 
-	// serviceDiscovry.Unregister(&registry.DefaultServiceInstance{
-	// 	Id:          id,
-	// 	ServiceName: serviceName,
-	// 	Host:        host,
-	// 	Port:        321,
-	// })
-	//
-	// serviceDiscovry.Unregister(&registry.DefaultServiceInstance{
-	// 	Id:          id,
-	// 	ServiceName: serviceName,
-	// 	Host:        "my.c",
-	// 	Port:        321,
-	// })
-
 	err := serviceDiscovry.Register(instance)
 	assert.Nil(t, err)
 
@@ -97,7 +87,6 @@ func TestNacosServiceDiscovery_CRUD(t *testing.T) {
 	assert.Equal(t, serviceName, instance.GetServiceName())
 	assert.Equal(t, 0, len(instance.GetMetadata()))
 
-
 	instance.Metadata["a"] = "b"
 
 	err = serviceDiscovry.Update(instance)
@@ -112,6 +101,19 @@ func TestNacosServiceDiscovery_CRUD(t *testing.T) {
 	instance = page.GetData()[0].(*registry.DefaultServiceInstance)
 	v, _ := instance.Metadata["a"]
 	assert.Equal(t, "b", v)
+
+	// test dispatcher event
+	err = serviceDiscovry.DispatchEventByServiceName(serviceName)
+	assert.Nil(t, err)
+
+	// test AddListener
+	err = serviceDiscovry.AddListener(&registry.ServiceInstancesChangedListener{})
+	assert.Nil(t, err)
+}
+
+func TestNacosServiceDiscovery_GetDefaultPageSize(t *testing.T) {
+	serviceDiscovry, _ := extension.GetServiceDiscovery(constant.NACOS_KEY, mockUrl())
+	assert.Equal(t, registry.DefaultPageSize, serviceDiscovry.GetDefaultPageSize())
 }
 
 func mockUrl() *common.URL {