Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
2
22a7f0099
Manage
Activity
Members
Labels
Plan
Issues
0
Issue boards
Milestones
Wiki
Code
Merge requests
0
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Build
Pipelines
Jobs
Pipeline schedules
Artifacts
Deploy
Releases
Package Registry
Operate
Environments
Terraform modules
Monitor
Incidents
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
Summer2022
22a7f0099
Commits
95b03c6a
Commit
95b03c6a
authored
4 years ago
by
cvictory
Browse files
Options
Downloads
Patches
Plain Diff
fix review issue
parent
c53e0f63
No related branches found
Branches containing commit
No related tags found
Tags containing commit
No related merge requests found
Changes
3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
config/application_config.go
+1
-0
1 addition, 0 deletions
config/application_config.go
protocol/dubbo/dubbo_invoker.go
+3
-3
3 additions, 3 deletions
protocol/dubbo/dubbo_invoker.go
protocol/dubbo/dubbo_invoker_test.go
+0
-3
0 additions, 3 deletions
protocol/dubbo/dubbo_invoker_test.go
with
4 additions
and
6 deletions
config/application_config.go
+
1
−
0
View file @
95b03c6a
...
...
@@ -19,6 +19,7 @@ package config
import
(
"github.com/apache/dubbo-go/common/constant"
"github.com/creasty/defaults"
)
...
...
This diff is collapsed.
Click to expand it.
protocol/dubbo/dubbo_invoker.go
+
3
−
3
View file @
95b03c6a
...
...
@@ -19,8 +19,6 @@ package dubbo
import
(
"context"
"github.com/apache/dubbo-go/config"
"github.com/apache/dubbo-go/remoting"
"strconv"
"strings"
"sync"
...
...
@@ -37,8 +35,10 @@ import (
"github.com/apache/dubbo-go/common"
"github.com/apache/dubbo-go/common/constant"
"github.com/apache/dubbo-go/common/logger"
"github.com/apache/dubbo-go/config"
"github.com/apache/dubbo-go/protocol"
invocation_impl
"github.com/apache/dubbo-go/protocol/invocation"
"github.com/apache/dubbo-go/remoting"
)
var
(
...
...
@@ -51,7 +51,7 @@ var (
attachmentKey
=
[]
string
{
constant
.
INTERFACE_KEY
,
constant
.
GROUP_KEY
,
constant
.
TOKEN_KEY
,
constant
.
TIMEOUT_KEY
}
)
// DubboInvoker
. It
is implement of protocol.Invoker.
One
dubboInvoker refer to one service and ip.
// DubboInvoker is implement of protocol.Invoker.
A
dubboInvoker refer to one service and ip.
type
DubboInvoker
struct
{
protocol
.
BaseInvoker
// the exchange layer, it is focus on network communication.
...
...
This diff is collapsed.
Click to expand it.
protocol/dubbo/dubbo_invoker_test.go
+
0
−
3
View file @
95b03c6a
...
...
@@ -57,9 +57,6 @@ func TestDubboInvoker_Invoke(t *testing.T) {
res
:=
invoker
.
Invoke
(
context
.
Background
(),
inv
)
assert
.
NoError
(
t
,
res
.
Error
())
assert
.
Equal
(
t
,
User
{
Id
:
"1"
,
Name
:
"username"
},
*
res
.
Result
()
.
(
*
User
))
//result will not contain attachment
// attachment in result it is useless.
//assert.Equal(t, "test_value", res.Attachments()["test_key"]) // test attachments for request/response
// CallOneway
inv
.
SetAttachments
(
constant
.
ASYNC_KEY
,
"true"
)
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment