Skip to content
Snippets Groups Projects
Commit 95b03c6a authored by cvictory's avatar cvictory
Browse files

fix review issue

parent c53e0f63
No related branches found
No related tags found
No related merge requests found
......@@ -19,6 +19,7 @@ package config
import (
"github.com/apache/dubbo-go/common/constant"
"github.com/creasty/defaults"
)
......
......@@ -19,8 +19,6 @@ package dubbo
import (
"context"
"github.com/apache/dubbo-go/config"
"github.com/apache/dubbo-go/remoting"
"strconv"
"strings"
"sync"
......@@ -37,8 +35,10 @@ import (
"github.com/apache/dubbo-go/common"
"github.com/apache/dubbo-go/common/constant"
"github.com/apache/dubbo-go/common/logger"
"github.com/apache/dubbo-go/config"
"github.com/apache/dubbo-go/protocol"
invocation_impl "github.com/apache/dubbo-go/protocol/invocation"
"github.com/apache/dubbo-go/remoting"
)
var (
......@@ -51,7 +51,7 @@ var (
attachmentKey = []string{constant.INTERFACE_KEY, constant.GROUP_KEY, constant.TOKEN_KEY, constant.TIMEOUT_KEY}
)
// DubboInvoker. It is implement of protocol.Invoker. One dubboInvoker refer to one service and ip.
// DubboInvoker is implement of protocol.Invoker. A dubboInvoker refer to one service and ip.
type DubboInvoker struct {
protocol.BaseInvoker
// the exchange layer, it is focus on network communication.
......
......@@ -57,9 +57,6 @@ func TestDubboInvoker_Invoke(t *testing.T) {
res := invoker.Invoke(context.Background(), inv)
assert.NoError(t, res.Error())
assert.Equal(t, User{Id: "1", Name: "username"}, *res.Result().(*User))
//result will not contain attachment
// attachment in result it is useless.
//assert.Equal(t, "test_value", res.Attachments()["test_key"]) // test attachments for request/response
// CallOneway
inv.SetAttachments(constant.ASYNC_KEY, "true")
......
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment