add test case

before_ut.bat

@@ -15,7 +15,8 @@
 ::  limitations under the License.
 
 set zkJar=zookeeper-3.4.9-fatjar.jar
-md remoting\zookeeper\zookeeper-4unittest\contrib\fatjar config_center\zookeeper\zookeeper-4unittest\contrib\fatjar registry\zookeeper\zookeeper-4unittest\contrib\fatjar
+md remoting\zookeeper\zookeeper-4unittest\contrib\fatjar config_center\zookeeper\zookeeper-4unittest\contrib\fatjar registry\zookeeper\zookeeper-4unittest\contrib\fatjar cluster\router\chain\zookeeper-4unittest\contrib\fatjar
 curl -L https://github.com/dubbogo/resources/raw/master/zookeeper-4unitest/contrib/fatjar/%zkJar% -o remoting/zookeeper/zookeeper-4unittest/contrib/fatjar/%zkJar%
 xcopy /f "remoting/zookeeper/zookeeper-4unittest/contrib/fatjar/%zkJar%" "config_center/zookeeper/zookeeper-4unittest/contrib/fatjar/"
-xcopy /f "remoting/zookeeper/zookeeper-4unittest/contrib/fatjar/%zkJar%" "registry/zookeeper/zookeeper-4unittest/contrib/fatjar/"
+xcopy /f "remoting/zookeeper/zookeeper-4unittest/contrib/fatjar/%zkJar%" "registry/zookeeper/zookeeper-4unittest/contrib/fatjar/"
\ No newline at end of file
+xcopy /f "remoting/zookeeper/zookeeper-4unittest/contrib/fatjar/%zkJar%" "cluster/router/chain/zookeeper-4unittest/contrib/fatjar/"
\ No newline at end of file

before_ut.sh

@@ -15,7 +15,8 @@
 #  limitations under the License.
 
 
-mkdir -p remoting/zookeeper/zookeeper-4unittest/contrib/fatjar config_center/zookeeper/zookeeper-4unittest/contrib/fatjar registry/zookeeper/zookeeper-4unittest/contrib/fatjar
+mkdir -p remoting/zookeeper/zookeeper-4unittest/contrib/fatjar config_center/zookeeper/zookeeper-4unittest/contrib/fatjar registry/zookeeper/zookeeper-4unittest/contrib/fatjar cluster/router/chain/zookeeper-4unittest/contrib/fatjar
 wget -P "remoting/zookeeper/zookeeper-4unittest/contrib/fatjar" https://github.com/dubbogo/resources/raw/master/zookeeper-4unitest/contrib/fatjar/zookeeper-3.4.9-fatjar.jar
 cp remoting/zookeeper/zookeeper-4unittest/contrib/fatjar/zookeeper-3.4.9-fatjar.jar config_center/zookeeper/zookeeper-4unittest/contrib/fatjar/
-cp remoting/zookeeper/zookeeper-4unittest/contrib/fatjar/zookeeper-3.4.9-fatjar.jar registry/zookeeper/zookeeper-4unittest/contrib/fatjar/
+cp remoting/zookeeper/zookeeper-4unittest/contrib/fatjar/zookeeper-3.4.9-fatjar.jar registry/zookeeper/zookeeper-4unittest/contrib/fatjar/
\ No newline at end of file
+cp remoting/zookeeper/zookeeper-4unittest/contrib/fatjar/zookeeper-3.4.9-fatjar.jar cluster/router/chain/zookeeper-4unittest/contrib/fatjar
\ No newline at end of file

cluster/router/chain/chain.go

@@ -52,16 +52,16 @@ func (c Chain) AddRouters(routers []router.Router) {
 	c.routers = newRouters
 }
 
-func NewRouterChain(url common.URL) *Chain {
+func NewRouterChain(url *common.URL) *Chain {
 	routerFactories := extension.GetRouters()
 	if len(routerFactories) == 0 {
 		return nil
 	}
 	routers := make([]router.Router, 0)
 	for _, routerFactory := range routerFactories {
-		r, err := routerFactory().Router(&url)
-		if err != nil {
-			logger.Errorf("router chain build router fail! error:%v", err)
+		r, err := routerFactory().Router(url)
+		if r == nil || err != nil {
+			logger.Errorf("router chain build router fail! error:%s", err.Error())
 			continue
 		}
 		routers = append(routers, r)

cluster/router/chain/chain_test.go

@@ -16,3 +16,42 @@
  */
 
 package chain
+
+import (
+	"context"
+	"github.com/apache/dubbo-go/common"
+	"github.com/apache/dubbo-go/common/extension"
+	_ "github.com/apache/dubbo-go/config_center/zookeeper"
+	"github.com/apache/dubbo-go/remoting/zookeeper"
+	"github.com/stretchr/testify/assert"
+	"testing"
+	"time"
+)
+
+import (
+	_ "github.com/apache/dubbo-go/cluster/router/condition"
+)
+
+func TestNewRouterChain(t *testing.T) {
+	ts, z, _, err := zookeeper.NewMockZookeeperClient("test", 15*time.Second)
+	assert.NoError(t, err)
+	defer ts.Stop()
+	defer z.Close()
+
+	t.Log(z.ZkAddrs)
+
+	zkUrl, _ := common.NewURL(context.TODO(), "zookeeper://127.0.0.1:2181")
+	configuration, err := extension.GetConfigCenterFactory("zookeeper").GetDynamicConfiguration(&zkUrl)
+	assert.Nil(t, err)
+	assert.NotNil(t, configuration)
+
+	chain := NewRouterChain(getRouteUrl("test"))
+	t.Log(chain.routers)
+}
+
+func getRouteUrl(applicationKey string) *common.URL {
+	url, _ := common.NewURL(context.TODO(), "condition://0.0.0.0/com.foo.BarService")
+	url.AddParam("application", applicationKey)
+	url.AddParam("force", "true")
+	return &url
+}

cluster/router/condition/app_router.go

@@ -31,8 +31,7 @@ type AppRouter struct {
 }
 
 func NewAppRouter(url *common.URL) (*AppRouter, error) {
-	appRouter := &AppRouter{}
-	err := appRouter.newListenableRouter(url, url.GetParam(constant.APPLICATION_KEY, ""))
+	appRouter, err := newListenableRouter(url, url.GetParam(constant.APPLICATION_KEY, ""))
 	if err != nil {
 		return nil, err
 	}

cluster/router/condition/listenable_router.go

@@ -49,28 +49,34 @@ type listenableRouter struct {
 	priority         int64
 }
 
-func (l *listenableRouter) newListenableRouter(url *common.URL, ruleKey string) error {
-	l.url = url
-	l.priority = DEFAULT_PRIORITY
+func newListenableRouter(url *common.URL, ruleKey string) (*AppRouter, error) {
 	if ruleKey == "" {
-		return nil
+		return nil, perrors.Errorf("newListenableRouter ruleKey is nil, can't create Listenable router")
 	}
+	l := &AppRouter{}
+
+	l.url = url
+	l.priority = DEFAULT_PRIORITY
 
 	routerKey := ruleKey + RULE_SUFFIX
 	//add listener
 	dynamicConfiguration := config.GetEnvInstance().GetDynamicConfiguration()
+	if dynamicConfiguration == nil {
+		return nil, perrors.Errorf("get dynamicConfiguration fail, dynamicConfiguration is nil, init config center plugin please")
+	}
+
 	dynamicConfiguration.AddListener(routerKey, l)
 	//get rule
 	rule, err := dynamicConfiguration.GetRule(routerKey, config_center.WithGroup(config_center.DEFAULT_GROUP))
 	if len(rule) == 0 || err != nil {
-		return perrors.Errorf("get rule fail, config rule{%s},  error{%v}", rule, err)
+		return nil, perrors.Errorf("get rule fail, config rule{%s},  error{%v}", rule, err)
 	}
 	l.Process(&config_center.ConfigChangeEvent{
 		Key:        routerKey,
 		Value:      rule,
 		ConfigType: remoting.EventTypeUpdate})
 
-	return nil
+	return l, nil
 }
 
 func (l *listenableRouter) Process(event *config_center.ConfigChangeEvent) {