Skip to content
Snippets Groups Projects
Commit ccf647c5 authored by Ooo0oO0o0oO's avatar Ooo0oO0o0oO
Browse files

fix comment issue

parent bc1dcb57
No related branches found
No related tags found
No related merge requests found
...@@ -30,8 +30,8 @@ import ( ...@@ -30,8 +30,8 @@ import (
) )
const ( const (
active = "active" active = "active"
dubbo_invoke_start_time = "dubbo_invoke_start_time" dubboInvokeStartTime = "dubboInvokeStartTime"
) )
func init() { func init() {
...@@ -44,16 +44,17 @@ type ActiveFilter struct { ...@@ -44,16 +44,17 @@ type ActiveFilter struct {
func (ef *ActiveFilter) Invoke(invoker protocol.Invoker, invocation protocol.Invocation) protocol.Result { func (ef *ActiveFilter) Invoke(invoker protocol.Invoker, invocation protocol.Invocation) protocol.Result {
logger.Infof("invoking active filter. %v,%v", invocation.MethodName(), len(invocation.Arguments())) logger.Infof("invoking active filter. %v,%v", invocation.MethodName(), len(invocation.Arguments()))
invocation.(*invocation2.RPCInvocation).SetAttachments(dubbo_invoke_start_time, strconv.FormatInt(protocol.CurrentTimeMillis(), 10)) invocation.(*invocation2.RPCInvocation).SetAttachments(dubboInvokeStartTime, strconv.FormatInt(protocol.CurrentTimeMillis(), 10))
protocol.BeginCount(invoker.GetUrl(), invocation.MethodName()) protocol.BeginCount(invoker.GetUrl(), invocation.MethodName())
return invoker.Invoke(invocation) return invoker.Invoke(invocation)
} }
func (ef *ActiveFilter) OnResponse(result protocol.Result, invoker protocol.Invoker, invocation protocol.Invocation) protocol.Result { func (ef *ActiveFilter) OnResponse(result protocol.Result, invoker protocol.Invoker, invocation protocol.Invocation) protocol.Result {
startTime, err := strconv.ParseInt(invocation.(*invocation2.RPCInvocation).AttachmentsByKey(dubbo_invoke_start_time, "0"), 10, 64) startTime, err := strconv.ParseInt(invocation.(*invocation2.RPCInvocation).AttachmentsByKey(dubboInvokeStartTime, "0"), 10, 64)
if err != nil { if err != nil {
panic("parse dubbo_invoke_start_time to int64 failed") result.SetError(err)
logger.Errorf("parse dubbo_invoke_start_time to int64 failed")
} }
elapsed := protocol.CurrentTimeMillis() - startTime elapsed := protocol.CurrentTimeMillis() - startTime
protocol.EndCount(invoker.GetUrl(), invocation.MethodName(), elapsed, result.Error() == nil) protocol.EndCount(invoker.GetUrl(), invocation.MethodName(), elapsed, result.Error() == nil)
......
...@@ -29,7 +29,7 @@ func TestActiveFilter_Invoke(t *testing.T) { ...@@ -29,7 +29,7 @@ func TestActiveFilter_Invoke(t *testing.T) {
invoker.EXPECT().Invoke(gomock.Any()).Return(nil) invoker.EXPECT().Invoke(gomock.Any()).Return(nil)
invoker.EXPECT().GetUrl().Return(url).Times(1) invoker.EXPECT().GetUrl().Return(url).Times(1)
filter.Invoke(invoker, invoc) filter.Invoke(invoker, invoc)
assert.True(t, invoc.AttachmentsByKey(dubbo_invoke_start_time, "") != "") assert.True(t, invoc.AttachmentsByKey(dubboInvokeStartTime, "") != "")
} }
...@@ -37,7 +37,7 @@ func TestActiveFilter_OnResponse(t *testing.T) { ...@@ -37,7 +37,7 @@ func TestActiveFilter_OnResponse(t *testing.T) {
c := protocol.CurrentTimeMillis() c := protocol.CurrentTimeMillis()
elapsed := 100 elapsed := 100
invoc := invocation.NewRPCInvocation("test", []interface{}{"OK"}, map[string]string{ invoc := invocation.NewRPCInvocation("test", []interface{}{"OK"}, map[string]string{
dubbo_invoke_start_time: strconv.FormatInt(c-int64(elapsed), 10), dubboInvokeStartTime: strconv.FormatInt(c-int64(elapsed), 10),
}) })
url, _ := common.NewURL(context.TODO(), "dubbo://192.168.10.10:20000/com.ikurento.user.UserProvider") url, _ := common.NewURL(context.TODO(), "dubbo://192.168.10.10:20000/com.ikurento.user.UserProvider")
filter := ActiveFilter{} filter := ActiveFilter{}
......
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment