Skip to content
Snippets Groups Projects
Commit e796e12d authored by 邹毅贤's avatar 邹毅贤
Browse files

fix review problems

parent 18fefc89
No related branches found
No related tags found
No related merge requests found
...@@ -129,10 +129,6 @@ func (c *apolloConfiguration) GetRule(key string, opts ...Option) (string, error ...@@ -129,10 +129,6 @@ func (c *apolloConfiguration) GetRule(key string, opts ...Option) (string, error
} }
func (c *apolloConfiguration) GetProperties(key string, opts ...Option) (string, error) { func (c *apolloConfiguration) GetProperties(key string, opts ...Option) (string, error) {
k := &Options{}
for _, opt := range opts {
opt(k)
}
/** /**
* when group is not null, we are getting startup configs(config file) from Config Center, for example: * when group is not null, we are getting startup configs(config file) from Config Center, for example:
* key=dubbo.propertie * key=dubbo.propertie
......
...@@ -36,8 +36,13 @@ type DynamicConfiguration interface { ...@@ -36,8 +36,13 @@ type DynamicConfiguration interface {
SetParser(parser.ConfigurationParser) SetParser(parser.ConfigurationParser)
AddListener(string, ConfigurationListener, ...Option) AddListener(string, ConfigurationListener, ...Option)
RemoveListener(string, ConfigurationListener, ...Option) RemoveListener(string, ConfigurationListener, ...Option)
//GetProperties get properties file
GetProperties(string, ...Option) (string, error) GetProperties(string, ...Option) (string, error)
//GetRule get Router rule properties file
GetRule(string, ...Option) (string, error) GetRule(string, ...Option) (string, error)
//GetInternalProperty get value by key in Default properties file(dubbo.properties)
GetInternalProperty(string, ...Option) (string, error) GetInternalProperty(string, ...Option) (string, error)
} }
......
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment