scsi: libsas: Drop SAS_DPRINTK() and revise logs levels
Like sas_printk() did previously, SAS_DPRINTK() offers little value now that libsas logs already have the "sas" prefix through pr_fmt(fmt). So it can be dropped. However, after reviewing some logs in libsas, it is noticed that debug level is too low in many instances. So this change drops SAS_DPRINTK() and revises some logs to a more appropriate level. However many stay at debug level, although some are significantly promoted. We add -DDEBUG for compilation so that we keep the debug messages by default, as before. All the pre-existing checkpatch errors for spanning messages across multiple lines are also fixed. Finally, all other references to printk() [apart from special formatting in sas_ata.c] are removed and replaced with appropriate pr_xxx(). Suggested-by:Joe Perches <joe@perches.com> Signed-off-by:
John Garry <john.garry@huawei.com> Signed-off-by:
Martin K. Petersen <martin.petersen@oracle.com>
Showing
- drivers/scsi/libsas/Makefile 2 additions, 0 deletionsdrivers/scsi/libsas/Makefile
- drivers/scsi/libsas/sas_ata.c 11 additions, 13 deletionsdrivers/scsi/libsas/sas_ata.c
- drivers/scsi/libsas/sas_discover.c 16 additions, 17 deletionsdrivers/scsi/libsas/sas_discover.c
- drivers/scsi/libsas/sas_expander.c 100 additions, 114 deletionsdrivers/scsi/libsas/sas_expander.c
- drivers/scsi/libsas/sas_init.c 3 additions, 3 deletionsdrivers/scsi/libsas/sas_init.c
- drivers/scsi/libsas/sas_internal.h 4 additions, 7 deletionsdrivers/scsi/libsas/sas_internal.h
- drivers/scsi/libsas/sas_port.c 11 additions, 12 deletionsdrivers/scsi/libsas/sas_port.c
- drivers/scsi/libsas/sas_scsi_host.c 58 additions, 65 deletionsdrivers/scsi/libsas/sas_scsi_host.c
- drivers/scsi/libsas/sas_task.c 2 additions, 5 deletionsdrivers/scsi/libsas/sas_task.c
Please register or sign in to comment