x86/asm: Move 'status' from thread_struct to thread_info
The TS_COMPAT bit is very hot and is accessed from code paths that mostly also touch thread_info::flags. Move it into struct thread_info to improve cache locality. The only reason it was in thread_struct is that there was a brief period during which arch-specific fields were not allowed in struct thread_info. Linus suggested further changing: ti->status &= ~(TS_COMPAT|TS_I386_REGS_POKED); to: if (unlikely(ti->status & (TS_COMPAT|TS_I386_REGS_POKED))) ti->status &= ~(TS_COMPAT|TS_I386_REGS_POKED); on the theory that frequently dirtying the cacheline even in pure 64-bit code that never needs to modify status hurts performance. That could be a reasonable followup patch, but I suspect it matters less on top of this patch. Suggested-by:Linus Torvalds <torvalds@linux-foundation.org> Signed-off-by:
Andy Lutomirski <luto@kernel.org> Signed-off-by:
Thomas Gleixner <tglx@linutronix.de> Reviewed-by:
Ingo Molnar <mingo@kernel.org> Acked-by:
Linus Torvalds <torvalds@linux-foundation.org> Cc: Borislav Petkov <bp@alien8.de> Cc: Kernel Hardening <kernel-hardening@lists.openwall.com> Link: https://lkml.kernel.org/r/03148bcc1b217100e6e8ecf6a5468c45cf4304b6.1517164461.git.luto@kernel.org
Showing
- arch/x86/entry/common.c 2 additions, 2 deletionsarch/x86/entry/common.c
- arch/x86/include/asm/processor.h 0 additions, 2 deletionsarch/x86/include/asm/processor.h
- arch/x86/include/asm/syscall.h 3 additions, 3 deletionsarch/x86/include/asm/syscall.h
- arch/x86/include/asm/thread_info.h 2 additions, 1 deletionarch/x86/include/asm/thread_info.h
- arch/x86/kernel/process_64.c 2 additions, 2 deletionsarch/x86/kernel/process_64.c
- arch/x86/kernel/ptrace.c 1 addition, 1 deletionarch/x86/kernel/ptrace.c
- arch/x86/kernel/signal.c 1 addition, 1 deletionarch/x86/kernel/signal.c
Please register or sign in to comment