Skip to content
Snippets Groups Projects
  1. Jan 03, 2013
    • Niels Ole Salscheider's avatar
      brcmsmac: Use udelay instead of usleep_range · 7ffa5928
      Niels Ole Salscheider authored
      
      wlc_lcnphy_rx_iq_cal_gain is called during initialization, i. e. when
      executing brcms_up.
      But brcms_up is called from brcms_ops_start while the latter holds a spin lock.
      Thus, we cannot use usleep_range but have to use udelay.
      
      This fixes:
      BUG: scheduling while atomic: NetworkManager/1652/0x00000200
      [...]
      Call Trace:
       [<ffffffff81582522>] __schedule_bug+0x48/0x54
       [<ffffffff815892b6>] __schedule+0x596/0x6d0
       [<ffffffff81589719>] schedule+0x29/0x70
       [<ffffffff8158893c>] schedule_hrtimeout_range_clock+0xfc/0x140
       [<ffffffff81060f10>] ? update_rmtp+0x70/0x70
       [<ffffffff81588993>] schedule_hrtimeout_range+0x13/0x20
       [<ffffffff810495e0>] usleep_range+0x40/0x50
       [<ffffffffa05dedcb>] wlc_lcnphy_rx_iq_cal.constprop.10+0x59b/0xa90 [brcmsmac]
       [<ffffffffa05df4ce>] wlc_lcnphy_periodic_cal+0x20e/0x220 [brcmsmac]
       [<ffffffffa05dce8d>] ? wlc_lcnphy_set_tx_pwr_ctrl+0x21d/0x3c0 [brcmsmac]
       [<ffffffffa05e0cfc>] wlc_phy_init_lcnphy+0xacc/0x1100 [brcmsmac]
       [<ffffffffa05e0230>] ? wlc_phy_txpower_recalc_target_lcnphy+0x90/0x90 [brcmsmac]
       [<ffffffffa05d7c7d>] wlc_phy_init+0xcd/0x170 [brcmsmac]
       [<ffffffffa05c9dfe>] brcms_b_bsinit.isra.65+0x12e/0x310 [brcmsmac]
       [<ffffffffa05d061b>] brcms_c_init+0x8fb/0x1170 [brcmsmac]
       [<ffffffffa05c3a0a>] brcms_init+0x5a/0x70 [brcmsmac]
       [<ffffffffa05ce76c>] brcms_c_up+0x1ac/0x4a0 [brcmsmac]
       [<ffffffffa05c3c65>] brcms_up+0x25/0x30 [brcmsmac]
       [<ffffffffa05c44c0>] brcms_ops_start+0xd0/0x100 [brcmsmac]
      [...]
      
      Signed-off-by: default avatarNiels Ole Salscheider <niels_ole@salscheider-online.de>
      Signed-off-by: default avatarJohn W. Linville <linville@tuxdriver.com>
      7ffa5928
    • Tomasz Guszkowski's avatar
      p54usb: add USB ID for T-Com Sinus 154 data II · 3194b7fc
      Tomasz Guszkowski authored
      
      Added USB ID for T-Com Sinus 154 data II.
      
      Cc: <stable@vger.kernel.org>
      Signed-off-by: default avatarTomasz Guszkowski <tsg@o2.pl>
      Acked-by: default avatarChristian Lamparter <chunkeey@googlemail.com>
      Signed-off-by: default avatarJohn W. Linville <linville@tuxdriver.com>
      3194b7fc
    • Christian Lamparter's avatar
      carl9170: fix -EINVAL bailout during init with !CONFIG_MAC80211_MESH · 6c653f66
      Christian Lamparter authored
      
      Sean reported that as of 3.7, his AR9170 device no longer works
      because the driver fails during initialization. He noted this
      is due to:
      "In carl9170/fw.c, ar->hw->wiphy is tagged with
      NL80211_IFTYPE_MESH_POINT support if the firmware has Content
      after Beacon Queuing. This is both in interface_modes and the
      only iface_combinations entry.
      
      If CONFIG_MAC80211_MESH is not set, ieee80211_register_hw
      removes NL80211_IFTYPE_MESH_POINT from interface_modes, but
      not iface_combinations.
      
      wiphy_register then checks to see if every interface type in
      every interface combination is in interface_modes.
      NL80211_IFTYPE_MESH_POINT was removed, so you get a WARN_ON
      warning and it returns -EINVAL, giving up."
      
      Unfortunately, the iface_combination (types) feature bitmap
      in ieee80211_iface_limit is part of a const member in the
      ieee80211_iface_combination struct. Hence, the MESH_POINT
      feature flag can't be masked by wiphy_register in the
      same way as interface_modes in ieee80211_register_hw.
      
      Cc: <stable@vger.kernel.org>
      Reported-by: default avatarSean Patrick Santos <quantheory@gmail.com>
      Signed-off-by: default avatarChristian Lamparter <chunkeey@googlemail.com>
      Tested-by: default avatarSean Patrick Santos <quantheory@gmail.com>
      Signed-off-by: default avatarJohn W. Linville <linville@tuxdriver.com>
      6c653f66
    • Jussi Kivilinna's avatar
      rtlwifi: fix incorrect use of usb_alloc_coherent with usb_control_msg · 4c3de592
      Jussi Kivilinna authored
      
      Incorrect use of usb_alloc_coherent memory as input buffer to usb_control_msg
      can cause problems in arch DMA code, for example kernel BUG at
      'arch/arm/include/asm/dma-mapping.h:321' on ARM (linux-3.4).
      
      Change _usb_writeN_sync use kmalloc'd buffer instead.
      
      Cc: stable@vger.kernel.org
      Signed-off-by: default avatarJussi Kivilinna <jussi.kivilinna@mbnet.fi>
      Acked-by: default avatarLarry Finger <Larry.Finger@lwfinger.net>
      Signed-off-by: default avatarJohn W. Linville <linville@tuxdriver.com>
      4c3de592
    • Sujith Manoharan's avatar
      ath9k: Fix compilation breakage · 12e94327
      Sujith Manoharan authored
      
      Since ath9k makes use of mac80211's debugfs hooks to
      maintain station statistics, make ATH9K_DEBUGFS
      select MAC80211_DEBUGFS. This fixes the issue reported by
      Fengguang Wu:
      
      drivers/net/wireless/ath/ath9k/debug.c: In function 'ath9k_sta_add_debugfs':
      drivers/net/wireless/ath/ath9k/debug.c:1589:4: error: 'struct ath_node' has no member named 'node_stat'
      drivers/net/wireless/ath/ath9k/debug.c: In function 'ath9k_sta_remove_debugfs':
      drivers/net/wireless/ath/ath9k/debug.c:1599:19: error: 'struct ath_node' has no member named 'node_stat'
      
      Reported-by: default avatarFengguang Wu <fengguang.wu@intel.com>
      Signed-off-by: default avatarSujith Manoharan <c_manoha@qca.qualcomm.com>
      Signed-off-by: default avatarJohn W. Linville <linville@tuxdriver.com>
      12e94327
    • Geert Uytterhoeven's avatar
      ssb: SSB_DRIVER_GPIO should depend on GPIOLIB instead of selecting it · 3194f2f0
      Geert Uytterhoeven authored
      
      Commit ec43b08b ("ssb: add GPIO driver")
      added SSB_DRIVER_GPIO, which unconditionally selects GPIOLIB, causing
      a Kconfig warning:
      
      warning: (ARCH_REQUIRE_GPIOLIB && SSB_DRIVER_GPIO && BCMA_DRIVER_GPIO && MFD_TC6393XB && FB_VIA) selects GPIOLIB which has unmet direct dependencies (ARCH_WANT_OPTIONAL_GPIOLIB || ARCH_REQUIRE_GPIOLIB)
      
      and build failure for m68k/allmodconfig:
      
      In file included from drivers/ssb/ssb_private.h:5,
                       from drivers/ssb/main.c:12:
      include/linux/ssb/ssb.h:440: error: field ‘gpio’ has incomplete type
      make[4]: *** [drivers/ssb/main.o] Error 1
      make[3]: *** [drivers/ssb/] Error 2
      
      Turn the select into a dependency to fix this.
      
      Signed-off-by: default avatarGeert Uytterhoeven <geert@linux-m68k.org>
      Signed-off-by: default avatarJohn W. Linville <linville@tuxdriver.com>
      3194f2f0
    • Geert Uytterhoeven's avatar
      bcma: BCMA_DRIVER_GPIO should depend on GPIOLIB instead of selecting it · a7333114
      Geert Uytterhoeven authored
      
      Commit cf0936b0 ("bcma: add GPIO driver")
      added BCMA_DRIVER_GPIO, which unconditionally selects GPIOLIB, causing
      a Kconfig warning:
      
      warning: (ARCH_REQUIRE_GPIOLIB && SSB_DRIVER_GPIO && BCMA_DRIVER_GPIO && MFD_TC6393XB && FB_VIA) selects GPIOLIB which has unmet direct dependencies (ARCH_WANT_OPTIONAL_GPIOLIB || ARCH_REQUIRE_GPIOLIB)
      
      and build failure for m68k/allmodconfig:
      
      In file included from include/linux/bcma/bcma.h:8,
                       from drivers/bcma/bcma_private.h:9,
                       from drivers/bcma/main.c:9:
      include/linux/bcma/bcma_driver_chipcommon.h:582: error: field ‘gpio’ has incomplete type
      In file included from include/linux/bcma/bcma.h:12,
                       from drivers/bcma/bcma_private.h:9,
                       from drivers/bcma/main.c:9:
      include/linux/ssb/ssb.h:440: error: field ‘gpio’ has incomplete type
      make[4]: *** [drivers/bcma/main.o] Error 1
      make[3]: *** [drivers/bcma/] Error 2
      
      Turn the select into a dependency to fix this.
      
      Signed-off-by: default avatarGeert Uytterhoeven <geert@linux-m68k.org>
      Signed-off-by: default avatarJohn W. Linville <linville@tuxdriver.com>
      a7333114
  2. Dec 22, 2012