Skip to content
Snippets Groups Projects
Commit d96ca30c authored by david regan's avatar david regan Committed by Yongqiang Liu
Browse files

mtd: rawnand: brcmnand: Fixed incorrect sub-page ECC status

stable inclusion
from stable-v4.19.231
commit c48771b7f7b086bca5a1094191b33c3c4324bf0b
category: bugfix
bugzilla: https://gitee.com/openeuler/kernel/issues/I5646A


CVE: N/A

------------------------------------------------

[ Upstream commit 36415a7964711822e63695ea67fede63979054d9 ]

The brcmnand driver contains a bug in which if a page (example 2k byte)
is read from the parallel/ONFI NAND and within that page a subpage (512
byte) has correctable errors which is followed by a subpage with
uncorrectable errors, the page read will return the wrong status of
correctable (as opposed to the actual status of uncorrectable.)

The bug is in function brcmnand_read_by_pio where there is a check for
uncorrectable bits which will be preempted if a previous status for
correctable bits is detected.

The fix is to stop checking for bad bits only if we already have a bad
bits status.

Fixes: 27c5b17c ("mtd: nand: add NAND driver "library" for Broadcom STB NAND controller")
Signed-off-by: default avatardavid regan <dregan@mail.com>
Reviewed-by: default avatarFlorian Fainelli <f.fainelli@gmail.com>
Signed-off-by: default avatarMiquel Raynal <miquel.raynal@bootlin.com>
Link: https://lore.kernel.org/linux-mtd/trinity-478e0c09-9134-40e8-8f8c-31c371225eda-1643237024774@3c-app-mailcom-lxa02


Signed-off-by: default avatarSasha Levin <sashal@kernel.org>

Conflicts:
	drivers/mtd/nand/raw/brcmnand/brcmnand.c
Signed-off-by: default avatarCui GaoSheng <cuigaosheng1@huawei.com>
Reviewed-by: default avatarXiu Jianfeng <xiujianfeng@huawei.com>
Signed-off-by: default avatarYongqiang Liu <liuyongqiang13@huawei.com>
parent f1434c1d
No related branches found
No related tags found
No related merge requests found
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment