Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
2
22b970408
Manage
Activity
Members
Labels
Plan
Issues
0
Issue boards
Milestones
Wiki
Code
Merge requests
0
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Build
Pipelines
Jobs
Pipeline schedules
Artifacts
Deploy
Releases
Package Registry
Operate
Environments
Terraform modules
Monitor
Incidents
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
Summer2022
22b970408
Commits
e25ff11f
Commit
e25ff11f
authored
10 years ago
by
Al Viro
Browse files
Options
Downloads
Patches
Plain Diff
split the slow path in acct_process() off
Signed-off-by:
Al Viro
<
viro@zeniv.linux.org.uk
>
parent
cdd37e23
No related branches found
Branches containing commit
No related tags found
Tags containing commit
No related merge requests found
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
kernel/acct.c
+28
-22
28 additions, 22 deletions
kernel/acct.c
with
28 additions
and
22 deletions
kernel/acct.c
+
28
−
22
View file @
e25ff11f
...
...
@@ -599,34 +599,35 @@ void acct_collect(long exitcode, int group_dead)
spin_unlock_irq
(
&
current
->
sighand
->
siglock
);
}
static
void
acct_process
_in_ns
(
struct
pid_namespace
*
ns
)
static
void
slow_
acct_process
(
struct
pid_namespace
*
ns
)
{
struct
file
*
file
=
NULL
;
struct
bsd_acct_struct
*
acct
;
for
(
;
ns
;
ns
=
ns
->
parent
)
{
struct
file
*
file
=
NULL
;
struct
bsd_acct_struct
*
acct
;
acct
=
ns
->
bacct
;
/*
* accelerate the common fastpath:
*/
if
(
!
acct
||
!
acct
->
file
)
return
;
acct
=
ns
->
bacct
;
/*
* accelerate the common fastpath:
*/
if
(
!
acct
||
!
acct
->
file
)
continue
;
spin_lock
(
&
acct_lock
);
file
=
acct
->
file
;
if
(
unlikely
(
!
file
))
{
spin_lock
(
&
acct_lock
);
file
=
acct
->
file
;
if
(
unlikely
(
!
file
))
{
spin_unlock
(
&
acct_lock
);
continue
;
}
get_file
(
file
);
spin_unlock
(
&
acct_lock
);
return
;
}
get_file
(
file
);
spin_unlock
(
&
acct_lock
);
do_acct_process
(
acct
,
ns
,
file
);
fput
(
file
);
do_acct_process
(
acct
,
ns
,
file
);
fput
(
file
);
}
}
/**
* acct_process - now just a wrapper around acct_process_in_ns,
* which in turn is a wrapper around do_acct_process.
* acct_process
*
* handles process accounting for an exiting task
*/
...
...
@@ -639,6 +640,11 @@ void acct_process(void)
* alive and holds its namespace, which in turn holds
* its parent.
*/
for
(
ns
=
task_active_pid_ns
(
current
);
ns
!=
NULL
;
ns
=
ns
->
parent
)
acct_process_in_ns
(
ns
);
for
(
ns
=
task_active_pid_ns
(
current
);
ns
!=
NULL
;
ns
=
ns
->
parent
)
{
struct
bsd_acct_struct
*
acct
=
ns
->
bacct
;
if
(
acct
&&
acct
->
file
)
break
;
}
if
(
unlikely
(
ns
))
slow_acct_process
(
ns
);
}
This diff is collapsed.
Click to expand it.
Preview
0%
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment