Skip to content
Snippets Groups Projects
  1. Dec 22, 2016
    • Luis de Bethencourt's avatar
      befs: add NFS export support · ac632f5b
      Luis de Bethencourt authored
      
      Implement mandatory export_operations, so it is possible to export befs via
      nfs.
      
      Signed-off-by: default avatarLuis de Bethencourt <luisbg@osg.samsung.com>
      ac632f5b
    • Luis de Bethencourt's avatar
      befs: remove trailing whitespaces · e60f749b
      Luis de Bethencourt authored
      
      Removing all trailing whitespaces in befs.
      
      I was skeptic about tainting the history with this, but whitespace changes
      can be ignored by using 'git blame -w' and 'git log -w'.
      
      Signed-off-by: default avatarLuis de Bethencourt <luisbg@osg.samsung.com>
      e60f749b
    • Luis de Bethencourt's avatar
      befs: remove signatures from comments · 50b00fc4
      Luis de Bethencourt authored
      
      No idea why some comments have signatures. These predate git. Removing them
      since they add noise and no information.
      
      Signed-off-by: default avatarLuis de Bethencourt <luisbg@osg.samsung.com>
      50b00fc4
    • Luis de Bethencourt's avatar
      befs: fix style issues in header files · 12ecb38d
      Luis de Bethencourt authored
      
      Fixing checkpatch.pl issues in befs header files:
      WARNING: Missing a blank line after declarations
      +       befs_inode_addr iaddr;
      +       iaddr.allocation_group = blockno >> BEFS_SB(sb)->ag_shift;
      
      WARNING: space prohibited between function name and open parenthesis '('
      +       return BEFS_SB(sb)->block_size / sizeof (befs_disk_inode_addr);
      
      ERROR: "foo * bar" should be "foo *bar"
      +                   const char *key, befs_off_t * value);
      
      ERROR: Macros with complex values should be enclosed in parentheses
      +#define PACKED __attribute__ ((__packed__))
      
      Signed-off-by: default avatarLuis de Bethencourt <luisbg@osg.samsung.com>
      12ecb38d
    • Luis de Bethencourt's avatar
      befs: fix style issues in linuxvfs.c · 62b80719
      Luis de Bethencourt authored
      
      Fix the following type of checkpatch.pl issues:
      WARNING: line over 80 characters
      +static struct dentry *befs_lookup(struct inode *, struct dentry *, unsigned int);
      
      ERROR: code indent should use tabs where possible
      +        if (!bi)$
      
      WARNING: please, no spaces at the start of a line
      +        if (!bi)$
      
      WARNING: labels should not be indented
      +      unacquire_bh:
      
      WARNING: space prohibited between function name and open parenthesis '('
      +                                             sizeof (struct befs_inode_info),
      
      WARNING: braces {} are not necessary for single statement blocks
      +       if (!*out) {
      +               return -ENOMEM;
      +       }
      
      WARNING: Block comments use a trailing */ on a separate line
      +        * in special cases */
      
      WARNING: Missing a blank line after declarations
      +               int token;
      +               if (!*p)
      
      ERROR: do not use assignment in if condition
      +       if (!(bh = sb_bread(sb, sb_block))) {
      
      ERROR: space prohibited after that open parenthesis '('
      +       if( befs_sb->num_blocks > ~((sector_t)0) ) {
      
      ERROR: space prohibited before that close parenthesis ')'
      +       if( befs_sb->num_blocks > ~((sector_t)0) ) {
      
      ERROR: space required before the open parenthesis '('
      +       if( befs_sb->num_blocks > ~((sector_t)0) ) {
      
      Signed-off-by: default avatarLuis de Bethencourt <luisbg@osg.samsung.com>
      62b80719
    • Luis de Bethencourt's avatar
      1ca7087e
    • Luis de Bethencourt's avatar
      befs: fix style issues in io.c · 4c7df645
      Luis de Bethencourt authored
      
      Fixing the two following checkpatch.pl issues:
      ERROR: trailing whitespace
      + * Based on portions of file.c and inode.c $
      
      WARNING: labels should not be indented
      +      error:
      
      Signed-off-by: default avatarLuis de Bethencourt <luisbg@osg.samsung.com>
      4c7df645
    • Luis de Bethencourt's avatar
      befs: fix style issues in inode.c · 85a06b30
      Luis de Bethencourt authored
      
      Fixing the following checkpatch.pl errors and warning:
      ERROR: trailing whitespace
      + * $
      
      WARNING: Block comments use * on subsequent lines
      +/*
      +       Validates the correctness of the befs inode
      
      ERROR: "foo * bar" should be "foo *bar"
      +befs_check_inode(struct super_block *sb, befs_inode * raw_inode,
      
      Signed-off-by: default avatarLuis de Bethencourt <luisbg@osg.samsung.com>
      85a06b30
    • Luis de Bethencourt's avatar
      befs: fix style issues in debug.c · a83179a8
      Luis de Bethencourt authored
      
      Fix all checkpatch.pl errors and warnings in debug.c:
      ERROR: trailing whitespace
      + * $
      
      WARNING: Missing a blank line after declarations
      +       va_list args;
      +       va_start(args, fmt);
      
      ERROR: "foo * bar" should be "foo *bar"
      +befs_dump_inode(const struct super_block *sb, befs_inode * inode)
      
      ERROR: "foo * bar" should be "foo *bar"
      +befs_dump_super_block(const struct super_block *sb, befs_super_block * sup)
      
      ERROR: "foo * bar" should be "foo *bar"
      +befs_dump_small_data(const struct super_block *sb, befs_small_data * sd)
      
      WARNING: line over 80 characters
      +befs_dump_index_entry(const struct super_block *sb, befs_disk_btree_super * super)
      
      ERROR: "foo * bar" should be "foo *bar"
      +befs_dump_index_entry(const struct super_block *sb, befs_disk_btree_super * super)
      
      ERROR: "foo * bar" should be "foo *bar"
      +befs_dump_index_node(const struct super_block *sb, befs_btree_nodehead * node)
      
      Signed-off-by: default avatarLuis de Bethencourt <luisbg@osg.samsung.com>
      a83179a8
  2. Dec 12, 2016
  3. Dec 11, 2016
  4. Dec 10, 2016
  5. Dec 09, 2016
  6. Dec 08, 2016
    • 추지호's avatar
      can: peak: fix bad memory access and free sequence · b67d0dd7
      추지호 authored
      
      Fix for bad memory access while disconnecting. netdev is freed before
      private data free, and dev is accessed after freeing netdev.
      
      This makes a slub problem, and it raise kernel oops with slub debugger
      config.
      
      Signed-off-by: default avatarJiho Chu <jiho.chu@samsung.com>
      Cc: linux-stable <stable@vger.kernel.org>
      Signed-off-by: default avatarMarc Kleine-Budde <mkl@pengutronix.de>
      b67d0dd7
    • Jeff Layton's avatar
      ceph: don't set req->r_locked_dir in ceph_d_revalidate · c3f4688a
      Jeff Layton authored
      This function sets req->r_locked_dir which is supposed to indicate to
      ceph_fill_trace that the parent's i_rwsem is locked for write.
      Unfortunately, there is no guarantee that the dir will be locked when
      d_revalidate is called, so we really don't want ceph_fill_trace to do
      any dcache manipulation from this context. Clear req->r_locked_dir since
      it's clearly not safe to do that.
      
      What we really want to know with d_revalidate is whether the dentry
      still points to the same inode. ceph_fill_trace installs a pointer to
      the inode in req->r_target_inode, so we can just compare that to
      d_inode(dentry) to see if it's the same one after the lookup.
      
      Also, since we aren't generally interested in the parent here, we can
      switch to using a GETATTR to hint that to the MDS, which also means that
      we only need to reserve one cap.
      
      Finally, just remove the d_unhashed check. That's really outside the
      purview of a filesystem's d_revalidate. If the thing became unhashed
      while we're checking it, then that's up to the VFS to handle anyway.
      
      Fixes: 200fd27c ("ceph: use lookup request to revalidate dentry")
      Link: http://tracker.ceph.com/issues/18041
      
      
      Reported-by: default avatarDonatas Abraitis <donatas.abraitis@gmail.com>
      Signed-off-by: default avatarJeff Layton <jlayton@redhat.com>
      Reviewed-by: default avatar"Yan, Zheng" <zyan@redhat.com>
      Signed-off-by: default avatarIlya Dryomov <idryomov@gmail.com>
      c3f4688a