Skip to content
Snippets Groups Projects
  1. Jul 22, 2015
  2. Jul 21, 2015
  3. Jul 20, 2015
  4. Jul 19, 2015
  5. Jul 18, 2015
  6. Jul 17, 2015
    • Takashi Iwai's avatar
      ALSA: pcm: Fix lockdep warning with nonatomic PCM ops · 67756e31
      Takashi Iwai authored
      
      With the nonatomic PCM ops, the system may spew lockdep warnings like:
      
       =============================================
       [ INFO: possible recursive locking detected ]
       4.2.0-rc1-jeejaval3 #12 Not tainted
       ---------------------------------------------
       aplay/4029 is trying to acquire lock:
        (snd_pcm_link_rwsem){.+.+.+}, at: [<ffffffff816fd473>] snd_pcm_stream_lock+0x43/0x60
      
       but task is already holding lock:
        (snd_pcm_link_rwsem){.+.+.+}, at: [<ffffffff816fcf29>] snd_pcm_action_nonatomic+0x29/0x80
      
       other info that might help us debug this:
        Possible unsafe locking scenario:
      
              CPU0
              ----
         lock(snd_pcm_link_rwsem);
         lock(snd_pcm_link_rwsem);
      
      Although this is false-positive as the rwsem is taken always as
      read-only for these code paths, it's certainly annoying to see this at
      any occasion.  A simple fix is to use down_read_nested() in
      snd_pcm_stream_lock() that can be called inside another lock.
      
      Reported-by: default avatarVinod Koul <vinod.koul@intel.com>
      Reported-by: default avatarJeeja Kp <jeeja.kp@intel.com>
      Tested-by: default avatarJeeja Kp <jeeja.kp@intel.com>
      Cc: <stable@vger.kernel.org>
      Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
      67756e31
  7. Jul 16, 2015
  8. Jul 14, 2015
  9. Jul 08, 2015
  10. Jul 06, 2015
  11. Jul 01, 2015
  12. Jun 30, 2015
    • Colin Ian King's avatar
      ALSA: Fix uninintialized error return · 0755e74b
      Colin Ian King authored
      
      Static analysis with cppcheck found the following error:
        [sound/core/init.c:118]: (error) Uninitialized variable: err
      
      ..this was introduced by commit 2471b6c8
      ("ALSA: info: Register proc entries recursively, too") where the call
      to snd_info_card_register was removed and no longer setting the error
      return in err.  When snd_info_create_card_entry fails to allocate a
      an entry, the error path exits with garbage in err.  Fix is to return
      -ENOMEM if entry fails to be allocated.
      
      Fixes: 2471b6c8 ("ALSA: info: Register proc entries recursively, too")
      Signed-off-by: default avatarColin Ian King <colin.king@canonical.com>
      Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
      0755e74b
  13. Jun 29, 2015
  14. Jun 27, 2015
  15. Jun 26, 2015
  16. Jun 25, 2015
  17. Jun 23, 2015
  18. Jun 22, 2015