Fix the bug 4662 (#4674)

Approved by: @fengttt

pkg/sql/colexec/mergetop/top.go

@@ -56,6 +56,11 @@ func Call(idx int, proc *process.Process, arg any) (bool, error) {
 	for {
 		switch ctr.state {
 		case Build:
+			if ap.Limit == 0 {
+				ctr.state = End
+				proc.Reg.InputBatch = nil
+				return true, nil
+			}
 			if err := ctr.build(ap, proc, anal); err != nil {
 				ctr.state = End
 				return true, err

pkg/sql/colexec/top/top.go

@@ -63,6 +63,12 @@ func Call(idx int, proc *process.Process, arg any) (bool, error) {
 			if len(bat.Zs) == 0 {
 				return false, nil
 			}
+			if ap.Limit == 0 {
+				ctr.state = End
+				bat.Clean(proc.GetMheap())
+				proc.Reg.InputBatch = nil
+				return true, nil
+			}
 			return false, ctr.build(ap, bat, proc)
 		case Eval:
 			ctr.state = End

pkg/sql/compile/compile_test.go

@@ -19,7 +19,6 @@ import (
 	"testing"
 
 	"github.com/matrixorigin/matrixone/pkg/container/batch"
-	"github.com/matrixorigin/matrixone/pkg/container/types"
 	"github.com/matrixorigin/matrixone/pkg/pb/plan"
 	"github.com/matrixorigin/matrixone/pkg/sql/parsers/dialect/mysql"
 	plan2 "github.com/matrixorigin/matrixone/pkg/sql/plan"
@@ -74,20 +73,6 @@ func TestCompile(t *testing.T) {
 	}
 }
 
-func TestEncode(t *testing.T) {
-	for _, tc := range tcs {
-		c := New("test", tc.sql, "", context.TODO(), tc.e, tc.proc, nil)
-		err := c.Compile(tc.pn, nil, testPrint)
-		require.NoError(t, err)
-		data, err := types.Encode(c.scope)
-		require.NoError(t, err)
-		s := new(Scope)
-		err = types.Decode(data, s)
-		require.NoError(t, err)
-		c.scope.equal(t, s)
-	}
-}
-
 func newTestCase(sql string, t *testing.T) compileTestCase {
 	proc := testutil.NewProcess()
 	e := memEngine.NewTestEngine()
@@ -107,25 +92,3 @@ func newTestCase(sql string, t *testing.T) compileTestCase {
 		},
 	}
 }
-
-func (s *Scope) equal(t *testing.T, r *Scope) {
-	require.Equal(t, s.Magic, r.Magic)
-	require.Equal(t, s.IsEnd, r.IsEnd)
-	require.Equal(t, s.Plan, r.Plan)
-	{
-		if s.DataSource != nil {
-			if s.DataSource.Bat != nil {
-				for i, vec := range s.DataSource.Bat.Vecs {
-					require.Equal(t, vec.Col, r.DataSource.Bat.Vecs[i].Col)
-				}
-			}
-			require.Equal(t, s.DataSource.SchemaName, r.DataSource.SchemaName)
-			require.Equal(t, s.DataSource.RelationName, r.DataSource.RelationName)
-			require.Equal(t, s.DataSource.Attributes, r.DataSource.Attributes)
-		}
-	}
-	require.Equal(t, s.NodeInfo, r.NodeInfo)
-	for i := range s.PreScopes {
-		s.PreScopes[i].equal(t, r.PreScopes[i])
-	}
-}

pkg/sql/compile/source.go

-// Copyright 2021 Matrix Origin
-//
-// Licensed under the Apache License, Version 2.0 (the "License");
-// you may not use this file except in compliance with the License.
-// You may obtain a copy of the License at
-//
-//      http://www.apache.org/licenses/LICENSE-2.0
-//
-// Unless required by applicable law or agreed to in writing, software
-// distributed under the License is distributed on an "AS IS" BASIS,
-// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-// See the License for the specific language governing permissions and
-// limitations under the License.
-
-package compile
-
-import "github.com/matrixorigin/matrixone/pkg/container/types"
-
-func (s *Source) MarshalBinary() ([]byte, error) {
-	return types.Encode(&EncodeSource{
-		Bat:          s.Bat,
-		SchemaName:   s.SchemaName,
-		RelationName: s.RelationName,
-		Attributes:   s.Attributes,
-	})
-}
-
-func (s *Source) UnmarshalBinary(data []byte) error {
-	rs := new(EncodeSource)
-	if err := types.Decode(data, rs); err != nil {
-		return err
-	}
-	s.Bat = rs.Bat
-	s.SchemaName = rs.SchemaName
-	s.RelationName = rs.RelationName
-	s.Attributes = rs.Attributes
-	return nil
-}

pkg/sql/compile/types.go

@@ -51,13 +51,6 @@ const (
 	InsertValues
 )
 
-type EncodeSource struct {
-	SchemaName   string
-	RelationName string
-	Attributes   []string
-	Bat          *batch.Batch
-}
-
 // Source contains information of a relation which will be used in execution,
 type Source struct {
 	SchemaName   string