fix review problems

common/url.go

@@ -313,7 +313,7 @@ func (c *URL) GetBackupUrls() []*URL {
 			WithUsername(c.Username),
 			WithPassword(c.Password),
 			WithPort(port),
-			WithParams(c.Params))
+			WithParams(c.params))
 
 		urls = append(urls, newURL)
 	}

config/condition_router_config.go

@@ -18,7 +18,6 @@ package config
 
 import (
 	"encoding/base64"
-	"fmt"
 	"io/ioutil"
 	"net/url"
 	"os"

config_center/dynamic_configuration.go

@@ -44,10 +44,6 @@ type DynamicConfiguration interface {
 
 	//GetInternalProperty get value by key in Default properties file(dubbo.properties)
 	GetInternalProperty(string, ...Option) (string, error)
-
-	GetConfig(string, ...Option) (string, error)
-	SetConfig(string, string, string) error
-	GetConfigs(string, ...Option) (string, error)
 }
 
 type Options struct {

config_center/mock_dynamic_config.go

@@ -97,15 +97,6 @@ func (c *MockDynamicConfiguration) GetConfig(key string, opts ...Option) (string
 	return c.content, nil
 }
 
-func (c *mockDynamicConfiguration) SetConfig(group string, key string, value string) error {
-	return nil
-}
-
-//For zookeeper, getConfig and getConfigs have the same meaning.
-func (c *MockDynamicConfiguration) GetConfigs(key string, opts ...Option) (string, error) {
-	return c.GetConfig(key, opts...)
-}
-
 func (c *MockDynamicConfiguration) Parser() parser.ConfigurationParser {
 	return c.parser
 }

registry/directory/directory_test.go

@@ -118,7 +118,7 @@ func Test_List(t *testing.T) {
 	registryDirectory, _ := normalRegistryDir()
 
 	time.Sleep(1e9)
-	invokers, _ := registryDirectory.List(&invocation.RPCInvocation{})
+	invokers := registryDirectory.List(&invocation.RPCInvocation{})
 	assert.Len(t, invokers, 3)
 	assert.Equal(t, true, registryDirectory.IsAvailable())