* Fix max path cycles for case where map has larger Y dimension than X dimension

* Improve readability

* fix ament_cpplint and ament_uncrustify issues

* Controllers should not be influenced by time jumps

Therefore use rclcpp::GenericRate<std::chrono::steady_clock> instead of
rclcpp::Rate

Signed-off-by: Martijn Buijs <martijn.buijs@gmail.com>

* Change to using `rclcpp::WallRate` for better readability

Signed-off-by: Martijn Buijs <martijn.buijs@gmail.com>

* Swap codecov orb for equivalent bash command

* Change working directory to find codecov.yml

* Clean root dir by moving codecov.yml to CI folder
still findable by codecov bash script

* Update .dockerignore file

* Fix RecoveryNode logic

Signed-off-by: Sarthak Mittal <sarthakmittal2608@gmail.com>

* Fix reset logic in all control nodes

Signed-off-by: Sarthak Mittal <sarthakmittal2608@gmail.com>

* Revert RoundRobin changes

Signed-off-by: Sarthak Mittal <sarthakmittal2608@gmail.com>

* Revert RoundRobin changes

Signed-off-by: Sarthak Mittal <sarthakmittal2608@gmail.com>

* Fix RecoveryNode halt

Signed-off-by: Sarthak Mittal <sarthakmittal2608@gmail.com>

Signed-off-by: Martijn Buijs <martijn.buijs@gmail.com>

* Add timeouts to all spin_until_future_complete calls

Signed-off-by: Sarthak Mittal <sarthakmittal2608@gmail.com>

* Update default timeout value

Signed-off-by: Sarthak Mittal <sarthakmittal2608@gmail.com>

* Add costmap filters with KeepoutFilter realization

* Cover preferred lanes in industries by KeepoutFilter (#1522)

* * Resolve review questions
* Add new OccupancyGrid class into nav2_util - API wrapper for original OccupancyGrid
* Add declareParameter() with one argument to Layer API

* Resolve 2nd review questions
* Remove OccupancyGrid class wrapper
* Add Costmap2D constructor with OccupancyGrid instead
* Add launch-file to help running CostmapFilterInfo publisher

* Code clean-up

* Resolve 3rd review questions (partially)

* Fix hidden problems during the shared handling of copstmap_ resource

* Cast into double during the linear conversion of OccupancyGrid data

* Add keepout_filter system test

* Add error message when base or multiplier is not set in ConstmapFilterInfo message

* Add comment to dummy info publisher launch-file

* Add costmap_conversion unit test

* Add declareParameter() unit test

* Add keepout zone entering check in Filte...

Signed-off-by: Sarthak Mittal <sarthakmittal2608@gmail.com>

* Fix nav2_waypoint_follower bugs

Signed-off-by: Sarthak Mittal <sarthakmittal2608@gmail.com>

* Update function description

Signed-off-by: Sarthak Mittal <sarthakmittal2608@gmail.com>

* Revert to simple simlinks
now that image builds are triggered by cron job on CI
rather than repository links on Docker Hub

* Parallelize install/build steps using multi stages
by cascading copies of manifests and workspaces

* Rename stages for installing dependencies

* Remove redundant ARGs and fix WORKDIRs
ARGs do not need to be redeclared for child stages

* Fix typo

* Simplify ARGs and WORKDIRs

* Write package list outside of workspace
to generalize skip up to pattern

* Simplify tests
Assume current WORKDIR
Don't use build mixins for test

* Add parallel stages for testing
use target arg to build added stages, e.g:
`docker build --target=underlay_tester ...`

* Add more comments

* Add simple stage to collect test results
and to easly build all other tester stages in parallel, e.g:
`docker build  --build-arg=RUN_TESTS=True --target=workspaces_tester`

* Initialize inflate_cone_ variable.

* initialize inflate_cone_ based on parameter.

* Increase the sleep time in the tests makes the costmap test always succeed on my machine.

* add test with only 2 points

* Added toPolygon test.

* Added test for footPrintFromString function.

* Add IsBatteryLow condition node

* Update default battery topic and switch to battery %

* Fix test

* Switch to sensor_msgs/BatteryState

* Add option to use voltage by default or switch to percentage

* Add sensor_msgs dependency in package.xml

* Make percentage default over voltage

* Update parameter list

* return if the number of waypoints is zero.

* terminate the action.

* Succeed action instead of terminating.

* fix invalid memory access

this fix was applied as part of the noetic release of costmap_2d

* uncrustify

* Fix memory leak in nav2_recoveries

* Fix recovery server memory leak (better interface)

* Fix costmap2d memory leak

* Fix nav2_navfn_planner memory leak

* Fix planner server and navfn planner memory leak

* Make all rclcpp::Node::SharedPtr argument passing const

* Fix controller server and DWB plugins memory leak

* Minor fixes

* Fix formatting errors

* Change all plugin interfaces to use weak_ptr intead of shared_ptr to parent rclcpp::Node

* Convert all SharedPtr to WeakPtr

* Check shared_ptr after lock and before dereferencing

* Fix tests declaring parameters real nodes don't

Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>

* Fix loadParameterWithDeprecation not getting initial parameter values

Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>

* Create sim_time variable before using it

Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>

* Line length < 100

Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>

* Add missing {

Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>

* Linter fixes

Signed-off-by: Shane Loretz <sloretz@openrobotics.org>

* sim_granularity -> time_granularity

Signed-off-by: Shane Loretz <sloretz@openrobotics.org>

* Linter fix

Signed-off-by: Shane Loretz <sloretz@openrobotics.org>

* remove path_updated blackboard variable to check if the path is updated

Signed-off-by: Daisuke Sato <daisukes@cmu.edu>

* remove path_udpated from tests

Signed-off-by: Daisuke Sato <daisukes@cmu.edu>

* make bt_action_node logic clear and fix test failures

Signed-off-by: Daisuke Sato <daisukes@cmu.edu>

* Revert "make bt_action_node logic clear and fix test failures"

This reverts commit bb29d801d504cf5de8c33524d01f76974f76e23a.

Signed-off-by: Daisuke Sato <daisukes@cmu.edu>

Signed-off-by: Daisuke Sato <daisukes@cmu.edu>

* Remove unused achor

* Trigger dockerhub build via cron job

* Rename workflow

* Change timezone
trigger dockerhub build 12 am pst
test nightly job 6am pst

* Clean up dockerhub job refrences

* Add missing executors for python_exec

* Remove unused devel folder

[WIP] removing rviz plugins from test coverage since its not a production run-time component (#1953)

* removing rviz plugins from test coverage since its not a production run-time component

* Update code_coverage_report.bash

The plan recieved is usually in global frame, but
our local costmap is often in odom frame. This
fixes a regression from #1857

To fix cpplint

* Use colcon to check for build failure
instead of canary file

* Simplify if case for shell

* Move extra dockerfiles to docker related folder

* Update Dockerfile location

* Stage refactor

* Use build kit

* Update underlay and overlay build

* Dockerfile tweek

* Rename underlay .repos file

* Remove uneeded key

* Clone matching distro branch by default

* Add optional directive to RUN colcon test

* Add comments

* Skip the use of symlinks

* Roll back to nightly image with all rmws
now that connext is fixed

* Add slam_toolbox to skipped rosdep keys

* Set DEBIAN_FRONTEND env to noninteractive

* Update to tag foxy

* Updated to latest codecov orb

* bump to 0.4.2

* removing nav2_bringup from binaries

Cleanup CircleCI config